Bug 151382 - UI: Keep ratio setting lost after opening Image properties Position and Size dialog, a change, OK and reopening the dialog
Summary: UI: Keep ratio setting lost after opening Image properties Position and Size ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.1.3 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:24.8.0 target:24.2.4
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Image-Dialog
  Show dependency treegraph
 
Reported: 2022-10-06 12:50 UTC by Telesto
Modified: 2024-05-19 19:06 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (24.26 KB, application/vnd.oasis.opendocument.text)
2022-10-06 12:51 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-10-06 12:50:48 UTC
Description:
UI: Keep ratio setting lost after opening Image properties Position and Size dialog, a change, OK and reopening the dialog

Steps to Reproduce:
1. Open the attached file
2. Select the image
3. Press F4 or Format -> Image -> Properties -> Position and Size Tab
4. Notice keep ratio being checked (fine)
5. Press Up in the Width spinbox to change the width -> Goes in sync (with keep ratio) -> Fine
6. Press OK
7. Press F4 or Format -> Image -> Properties -> Position and Size Tab

Actual Results:
Keep ratio unchecked at reopening the dialog

Expected Results:
Still checked


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 9063d99ff5ee43cc1239fc1dbb5d9897bdda1c9b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Telesto 2022-10-06 12:51:05 UTC
Created attachment 182869 [details]
Example file
Comment 2 Dieter 2022-10-21 15:55:30 UTC
I confirm it with

Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL
Comment 3 Gerald Pfeifer 2023-09-22 23:50:39 UTC
Still the case with

  Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
  Build ID: a4522ef5ce6a625054d83ec907aee07c156e94ed
  CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

for the example file attached here.

*Not* for a newly created document, though, interestingly?
Comment 4 Stéphane Guillou (stragu) 2024-05-07 12:04:35 UTC
Reproduced in recent daily build:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7a895ec4205659038aa95941b65715fed1a3e7be
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

... and in 7.3.7, but no repro in:

Version: 7.3.0.3 / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL

Bibisected with linux-64-7.3 repo to first bad build [596229b236011767a88288b8f3e10a929e95577b] which is 27b03993c49b3c8a3bafa736db9ca25e834a2195, a cherrypick of:

commit a59952f64c6e78f8e5bad6d6ab8373879f6a826f
author	Caolán McNamara 	Wed Feb 09 13:54:42 2022 +0000
committer	Caolán McNamara 	Wed Feb 09 20:59:06 2022 +0100
Resolves: tdf#132591 set property if Fixed Ratio checkbox was toggled
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129730

Caolán, can you please have a look?
Comment 5 Caolán McNamara 2024-05-19 14:11:34 UTC
bug#132591 has to keep working along with this case
Comment 6 Commit Notification 2024-05-19 18:08:54 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d0702a3f17c1fbd1b8ffb9ca0b275943e1a1f442

Resolves: tdf#151382 we want to save the FN_KEEP_ASPECT_RATIO state

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2024-05-19 18:12:03 UTC
seems good in trunk, backport to 24.2 in gerrit
Comment 8 Commit Notification 2024-05-19 19:06:09 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/bf877f3e10c3a2ce7267335a0c9c7cd828c373ca

Resolves: tdf#151382 we want to save the FN_KEEP_ASPECT_RATIO state

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.