Summary: | UI: Keep ratio setting lost after opening Image properties Position and Size dialog, a change, OK and reopening the dialog | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Telesto <telesto> |
Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caolan.mcnamara, dgp-mail, gerald, stephane.guillou |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 7.3.1.3 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=125239 https://bugs.documentfoundation.org/show_bug.cgi?id=132591 |
||
Whiteboard: | target:24.8.0 target:24.2.4 | ||
Crash report or crash signature: | Regression By: | Caolán McNamara | |
Bug Depends on: | |||
Bug Blocks: | 103270 | ||
Attachments: | Example file |
Description
Telesto
2022-10-06 12:50:48 UTC
Created attachment 182869 [details]
Example file
I confirm it with Version: 7.4.2.3 (x64) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Still the case with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a4522ef5ce6a625054d83ec907aee07c156e94ed CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US for the example file attached here. *Not* for a newly created document, though, interestingly? Reproduced in recent daily build: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 7a895ec4205659038aa95941b65715fed1a3e7be CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded ... and in 7.3.7, but no repro in: Version: 7.3.0.3 / LibreOffice Community Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL Bibisected with linux-64-7.3 repo to first bad build [596229b236011767a88288b8f3e10a929e95577b] which is 27b03993c49b3c8a3bafa736db9ca25e834a2195, a cherrypick of: commit a59952f64c6e78f8e5bad6d6ab8373879f6a826f author Caolán McNamara Wed Feb 09 13:54:42 2022 +0000 committer Caolán McNamara Wed Feb 09 20:59:06 2022 +0100 Resolves: tdf#132591 set property if Fixed Ratio checkbox was toggled Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129730 Caolán, can you please have a look? bug#132591 has to keep working along with this case Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d0702a3f17c1fbd1b8ffb9ca0b275943e1a1f442 Resolves: tdf#151382 we want to save the FN_KEEP_ASPECT_RATIO state It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. seems good in trunk, backport to 24.2 in gerrit Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/bf877f3e10c3a2ce7267335a0c9c7cd828c373ca Resolves: tdf#151382 we want to save the FN_KEEP_ASPECT_RATIO state It will be available in 24.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |