Bug 159695 - Validity settings are editable on a protected sheet from context menu
Summary: Validity settings are editable on a protected sheet from context menu
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0
Keywords:
Depends on:
Blocks: Cell-Validity
  Show dependency treegraph
 
Reported: 2024-02-12 14:29 UTC by Gabor Kelemen (allotropia)
Modified: 2024-05-31 06:11 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Example file from Excel (8.77 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2024-02-12 14:29 UTC, Gabor Kelemen (allotropia)
Details
The example file in Excel with disabled data validation, and in Calc with dialog opened from the context menu (68.65 KB, image/png)
2024-02-12 14:30 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-02-12 14:29:41 UTC
Created attachment 192526 [details]
Example file from Excel

In a protected sheet it is still possible to change data validation conditions from the context menu, but not from the main menu.

1. Open attached file
-> Check in Data menu that the Validity item is disabled - good
2. Right click on one of the numbers, select Validity
-> Menu item is not disabled, the Validity dialog opens - bad.


Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3d3242ef3a6f111d6220c60d5c1b968c7f46fc5f
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: default

Seems to have been started in 6.1 when the Validity menu item was added to the context menu for the first time.
Comment 1 Gabor Kelemen (allotropia) 2024-02-12 14:30:25 UTC
Created attachment 192527 [details]
The example file in Excel with disabled data validation, and in Calc with dialog opened from the context menu
Comment 2 ady 2024-02-12 15:20:47 UTC
(In reply to Gabor Kelemen (allotropia) from comment #0)

> 1. Open attached file
> -> Check in Data menu that the Validity item is disabled - good
> 2. Right click on one of the numbers, select Validity
> -> Menu item is not disabled, the Validity dialog opens - bad.

I can repro these steps with attachment 192526 [details] and on a new ods file on a recent LO 24.8 alpha, but, to be clear, when I attempt to actually modify the fields in the Data Validation dialogue, the result is the Information message that the "Protected cells can not be modified".

So:
* The Data Validation > Validity dialogue is reachable;
* The fields and values in the Data Validity dialogue are seen and they _seem_ to be editable.
* But none of the fields, values or settings of the Validity dialogue are actually modified.


Side comment:

"Calc menu Data > Validity..."

vs.

"Calc cell context menu > Data Validation..."

Validation (as in Excel) vs Validity.
Comment 3 Commit Notification 2024-05-31 06:11:03 UTC
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0d3bb65620de64709d45c6e9b5591381a7da8dcf

tdf#159695 Disable Data Validation in protected sheets

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.