Bug 159573 - Show most important changes for new releases in a dialog
Summary: Show most important changes for new releases in a dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
URL:
Whiteboard: target:24.8.0
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-05 14:13 UTC by Heiko Tietze
Modified: 2024-05-22 19:21 UTC (History)
11 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot with https://gerrit.libreoffice.org/c/core/+/163739 PS 15 in place for discussion there (206.27 KB, image/png)
2024-03-13 08:41 UTC, Michael Weghorn
Details
Welcome "blends into every" os (212.27 KB, image/png)
2024-03-29 12:03 UTC, V Stuart Foote
Details
generic single LO FTW panel after initial install change to ooSetupLastVersion (33.65 KB, image/png)
2024-03-29 13:28 UTC, V Stuart Foote
Details
Navigation elements cut off with kf6 (901 bytes, image/png)
2024-05-15 11:38 UTC, Buovjaga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2024-02-05 14:13:16 UTC
We announce all the great new features in release notes and inform users via infobar. That's not really convenient, and the stacked infobars are awkward anyway. The idea is to show a dialog with a carousel with images and short text updated on each release, all edited before the release by the marketing team.

Shouldn't be too hard to implement. A code pointer might be the tipoftheday dialog  cui/source/dialogs/tipofthedaydlg.cxx, initial release at https://gerrit.libreoffice.org/c/core/+/69498
Comment 1 V Stuart Foote 2024-02-05 14:23:58 UTC
So like the infobar "triggered" on first use (recorded to profile). 

No objection, but seems like it would get stale very quickly and then the dialog would just sit there as crud on users system until the next upgrade?

Also, with MAR now back on track when would the first use to expose the new dialog be shown--frequency of the dialog release?
Comment 2 Heiko Tietze 2024-02-05 14:35:48 UTC
We store the version and show the whatsnew infobar right now. Guess this will be the same for incremental MAR updates too.

include/unotools/VersionConfig.hxx isProductVersionUpgraded() checks the version number

And yes, the dialog lingers on the system until the next release. A few bytes of storages are wasted.
Comment 3 Stéphane Guillou (stragu) 2024-02-05 14:47:09 UTC
See also bug 69042, which started as the same request.

The challenge as I see it:
- picking the "most important ones" is tricky and subjective - but marketing can have the final word (with input from ESC?)
- it would have to be done before string freeze, but release notes are often far from complete at string freeze.

Other software also have a "What's new?" menu item, I think we should have it too (even if the dialog is not implemented - just linking to the wiki).
Comment 4 Stephan Bergmann 2024-02-05 16:18:01 UTC
(In reply to Heiko Tietze from comment #2)
> We store the version and show the whatsnew infobar right now. Guess this
> will be the same for incremental MAR updates too.

yes, all the bits in ini-files etc. should be the same after a MAR-based upgrade and an upgrade where you install a new .msi
Comment 5 John Mills 2024-02-15 11:10:01 UTC
If an carousel of images are shown after first start why don't we also give users some added info that LibreOffice uses extensions, provides alternative user interface options can save by default to other file formats etc. This proposal has been made on numerous occasions.

Until inplace upgrades are really working on Windows then you'll only see this once anyway.
Comment 6 Heiko Tietze 2024-02-15 13:39:41 UTC
(In reply to John Mills from comment #5)
> why don't we also give users some added info that LibreOffice uses extensions, 
> provides alternative user interface options

This would be bug 137931, and I think most users don't want to be bothered by "random" options. But if the Notebookbar would be on the marketing list of new features it is going to be advertised on this WhatsNew dialog.
Comment 7 Michael Weghorn 2024-03-13 08:41:25 UTC
Created attachment 193090 [details]
Screenshot with https://gerrit.libreoffice.org/c/core/+/163739 PS 15 in place for discussion there
Comment 8 Commit Notification 2024-03-27 08:42:31 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dd889b290304b73f96a9a8e6e0f144d3aa2ba7e1

Resolves tdf#159573 and tdf#137931 - WhatsNew or Welcome dialog

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 V Stuart Foote 2024-03-29 12:03:22 UTC
Created attachment 193386 [details]
Welcome "blends into every" os

Regards marketing "copy" on the 3rd Welcome screen "LibreOffice blends into every operating system and provides full customization" atop a set of screenclips of MUFFIN Notebook Bar 'Tabbed' UI.

Could be better if the artwork shows clips of the 'User Interface...' picker dialog, a panel in the 'Tabbed' UI, same panel in the 'Standard Toolbar' UI, and a clip of the 'Customize...' dialog. 

20240329 nightly
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: aef28c23adc87b8e26eacb56c7dbcf652e907fb9
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 10 V Stuart Foote 2024-03-29 13:28:10 UTC
Created attachment 193387 [details]
generic single LO FTW panel after initial install change to ooSetupLastVersion

(In reply to V Stuart Foote from comment #9)
Getting this generic single panel for 24.8 after changing ooSetupLastVersion stanza in the .xcu

Edit of the Stanza value won't do it, only if I delete the stanza from the .xcu will it show the four delivered panels.

@Heiko, is this intended/desired?
Comment 11 V Stuart Foote 2024-03-29 13:39:10 UTC
(In reply to V Stuart Foote from comment #10)
> @Heiko, is this intended/desired?

Oh wait, that is the difference between the WELCOME array and WHATSNEW array--and the commit [1] clearly says to 'clear' the .xcu staza to get back to the Welcome, while an .xcu stanza edit would take you to the latest for the build.

Cool! Just needs some love from Marketing... 

=-ref-=
[1] https://gerrit.libreoffice.org/c/core/+/163739
Comment 12 Heiko Tietze 2024-03-30 07:26:48 UTC
(In reply to V Stuart Foote from comment #10)
> @Heiko, is this intended/desired?
Yes, a new installation is identified by the field being empty. And as you figured out, a value difference is interpreted as an update.
Comment 13 Buovjaga 2024-05-15 11:38:29 UTC
Created attachment 194125 [details]
Navigation elements cut off with kf6

Cut off glitch observed in

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 78e0626bc7bf37d1eda2e3151dd1a44056f92032
CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Comment 14 V Stuart Foote 2024-05-15 14:37:34 UTC
(In reply to Buovjaga from comment #13)
> ...
> Cut off glitch observed in
> 
> Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 78e0626bc7bf37d1eda2e3151dd1a44056f92032
> CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+wayland)
> Locale: fi-FI (fi_FI.UTF-8); UI: en-US
> Calc: threaded

No issues in the Next/Previous panel dots with the Windows builds, Skia based or GDI vcl rendering (though antialiasing does look odd with the GDI rendering).  

20240514 TB77 nightly
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 47664e282da4999b8e471a6a916d7ec80414ac18
CPU threads: 8; OS: Windows 10 X86_64 (10.0 build 19045); UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded


@Italo, Mike -- string freeze for 24.8 approaching. Copy and graphics for the new Welcome panels?
Comment 15 Michael Weghorn 2024-05-15 15:12:45 UTC
(In reply to Buovjaga from comment #13)
> Created attachment 194125 [details]
> Navigation elements cut off with kf6
> 
> Cut off glitch observed in
> 
> Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 78e0626bc7bf37d1eda2e3151dd1a44056f92032
> CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+wayland)
> Locale: fi-FI (fi_FI.UTF-8); UI: en-US
> Calc: threaded

I basically get the same with SAL_USE_VCLPLUGIN=gen, except that the fill color of the first circle is read instead of blue.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bcc1b9f22d4b2772c735176e78dfa1e7c8c39b3a
CPU threads: 32; OS: Linux 6.7; UI render: default; VCL: x11
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: CL threaded
Comment 16 Heiko Tietze 2024-05-16 08:22:45 UTC
The question came up how to test the WhatsNew/Welcome dialog in master.

The Welcome dialog shows up when you restart the application in safe-mode (Help > "Restart in Safe Mode..." and "Continue in Safe Mode"); to test a second time you have to run the application once without safe mode.

The WhatsNew dialog starts if you change the value for ooSetupLastVersion to something below the ooSetupVersion (which grows in case of a real update) via Tools > Options > Advanced > Open Expert Configuration. You have to change the value again to retest.
https://i.imgur.com/YVdFVj6.png
Comment 17 Commit Notification 2024-05-16 10:50:11 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7fc7d3b9fe6eabeddf43fbf72a041854fda51b27

Related tdf#159573 - WhatsNew dialog: 1px glitch with Wayland

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 V Stuart Foote 2024-05-16 11:35:13 UTC
(In reply to Heiko Tietze from comment #16)
> The question came up how to test the WhatsNew/Welcome dialog in master.
> 
> The Welcome dialog shows up when you restart the application in safe-mode
> (Help > "Restart in Safe Mode..." and "Continue in Safe Mode"); to test a
> second time you have to run the application once without safe mode.
> 
> The WhatsNew dialog starts if you change the value for ooSetupLastVersion to
> something below the ooSetupVersion (which grows in case of a real update)
> via Tools > Options > Advanced > Open Expert Configuration. You have to
> change the value again to retest.

Or more simply just delete the stanza in user profile .xcu, will force it without doing version test:

<item oor:path="/org.openoffice.Setup/Product"><prop oor:name="ooSetupLastVersion" oor:op="fuse"><value>24.8</value></prop></item>
Comment 19 Buovjaga 2024-05-16 13:21:13 UTC
Thanks, now the clipping is gone

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 98142886f21e40d0f7052f18108d9586f4b2fbc5
CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Comment 20 Heiko Tietze 2024-05-22 19:20:54 UTC
Reverted for bug 161031; should be done via some HTML page
Comment 21 Heiko Tietze 2024-05-22 19:21:33 UTC
-161031 +161209