Bug 148691 - copy and paste a frame containing a shape duplicates the shape outside the frame
Summary: copy and paste a frame containing a shape duplicates the shape outside the frame
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.6.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Frame Clipboard
  Show dependency treegraph
 
Reported: 2022-04-20 17:45 UTC by Jean-Baptiste Faure
Modified: 2024-05-03 17:29 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Baptiste Faure 2022-04-20 17:45:31 UTC
Description:
When I copy and paste frame that contains a shape, the shape is duplicated outside the frame.
This bug is a regression (it works as expected in LO 7.1) that is caused by this commit : https://git.libreoffice.org/core/+/3cfd63cb55ab1a7e6df53eaeb2a7623be05983d0

Steps to Reproduce:
1. open a new empty text document
2. insert a frame using menu Insert > Frame > Frame Interactively
3. draw the frame
4. click outside the frame, then inside, the menu Insert > Shape > Symbol Shapes > Smiley Face
5. draw the shape with the mouse
6. click outside the frame, then select the frame
7. ctrl+C then ctrl+V
8. move the new frame

Actual Results:
you can see 2 frames each containing the shape, plus a third shape alone on the page

Expected Results:
You should see only 2 frames each containing the shape.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
After bisection on branch 7.2, it appears that this regression is caused by this commit : 
https://git.libreoffice.org/core/+/84c8adb703906b0fe2c7f9a5e7174e00139a08f3

The parent commit in the master branch is :
https://git.libreoffice.org/core/+/3cfd63cb55ab1a7e6df53eaeb2a7623be05983d0
Comment 1 Jean-Baptiste Faure 2022-04-20 17:48:19 UTC
Hi Bjoern,

Please, could you have a look at this regression?

Best regards.
JBF
Comment 2 Patrick Charlot 2022-04-20 18:02:59 UTC
I do reproduce this behavior with version 7.3.2.2. 
It seems it is a regression because I used to use frame in version 7.1 and I've never encountered this problem.

Regards
Patrick
Comment 3 cornosier 2022-04-20 18:04:02 UTC
I confirm on the versions

Version: 7.3.0.3 / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 6; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded


Version: 7.3.0.2 / LibreOffice Community
Build ID: f1c9017ac60ecca268da7b1cf147b10e244b9b21
CPU threads: 6; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded
Comment 4 sdc.blanco 2022-04-20 18:22:00 UTC
Also repro (for all possible anchoring of shape to frame) with:  

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: f8e11c6480ff0005715b989a6d4e2e10a3816cf6
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL
Comment 5 ocleyr2lalune@zaclys.net 2022-04-21 12:48:24 UTC
I reproduce in 7.3.2.2
Version: 7.3.2.2 / LibreOffice Community
Build ID: 454130fadb9a820d3728b86ccb63c8f359d70528
CPU threads: 4; OS: Linux 5.16; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

To confirm the regression
 in 7.2.6.2 I don't reproduce
Version: 7.2.6.2
Build ID: 20(Build:2)
CPU threads: 4; OS: Linux 5.16; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threadedVersion: 7.2.6.2

Regards

Claire
Comment 6 QA Administrators 2024-04-21 03:15:53 UTC Comment hidden (obsolete)
Comment 7 Jean-Baptiste Faure 2024-05-03 17:29:38 UTC
I do not reproduce anymore in LibreOffice 24.2. That said it seems that something changed in the behavior of the submenu Insert > Shape > Symbol Shapes. Indeed selecting an entry in this submenu adds a checkbox in front of this entry keeping it selected so that you can insert the same frame several times without reopening the same submenu. Right-clicking deselects the submenu entry. As a consequence, the 6th step to reproduce, should be changed in
6. right-click outside the frame, then select the frame

Doing this way I do not reproduce the issue anymore.

Closing as WorksForMe

Best regards.
JBF