Bug 146311 - Images Properties sidebar shows Columns section in Calc/Impress/Draw
Summary: Images Properties sidebar shows Columns section in Calc/Impress/Draw
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Gabor Kelemen (allotropia)
URL:
Whiteboard: target:7.4.0 target:7.3.0.0.beta2
Keywords: bibisected, implementationError
Depends on:
Blocks: Sidebar-Properties
  Show dependency treegraph
 
Reported: 2021-12-19 08:21 UTC by Gabor Kelemen (allotropia)
Modified: 2021-12-20 15:57 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Example file from Calc with image, mp3 media, shape (786.84 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-12-19 08:21 UTC, Gabor Kelemen (allotropia)
Details
Example file from Impress with image, shape (49.36 KB, application/vnd.oasis.opendocument.presentation)
2021-12-19 08:22 UTC, Gabor Kelemen (allotropia)
Details
The Properties sidebar in Calc with Columns section after selecting the image (125.25 KB, image/png)
2021-12-19 08:27 UTC, Gabor Kelemen (allotropia)
Details
The Properties sidebar in Calc with Columns section after selecting the mp3 media (117.35 KB, image/png)
2021-12-19 08:30 UTC, Gabor Kelemen (allotropia)
Details
The Properties sidebar in Impress with Columns section after selecting the image (126.17 KB, image/png)
2021-12-19 08:33 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2021-12-19 08:21:51 UTC
Created attachment 177012 [details]
Example file from Calc with image, mp3 media, shape

This is a followup to bug 146236.

Clicking on an image or media file in Calc or an image in Impress/Draw shows the Columns section in the sidebar.

Columns work only for drawing shapes, so we should not show them in images/media files.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d47628f287f4377394c4ff488c433bfe254b6abe
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Gabor Kelemen (allotropia) 2021-12-19 08:22:19 UTC
Created attachment 177013 [details]
Example file from Impress with image, shape
Comment 2 Gabor Kelemen (allotropia) 2021-12-19 08:27:57 UTC
Created attachment 177014 [details]
The Properties sidebar in Calc with Columns section after selecting the image
Comment 3 Gabor Kelemen (allotropia) 2021-12-19 08:30:58 UTC
Created attachment 177015 [details]
The Properties sidebar in Calc with Columns section after selecting the mp3 media
Comment 4 Gabor Kelemen (allotropia) 2021-12-19 08:33:18 UTC
Created attachment 177016 [details]
The Properties sidebar in Impress with Columns section after selecting the image
Comment 5 Mike Kaganski 2021-12-19 09:05:29 UTC
Note that unlike in Writer, typing when an image is selected does add text to images in Draw. So does it actually make sense to remove the panel there? If it doesn't work correctly, it's a different thing?
Comment 6 Gabor Kelemen (allotropia) 2021-12-19 11:04:22 UTC
Proposed patch at https://gerrit.libreoffice.org/c/core/+/127092
Comment 7 Gabor Kelemen (allotropia) 2021-12-20 07:10:26 UTC
(In reply to Mike Kaganski from comment #5)
> Note that unlike in Writer, typing when an image is selected does add text
> to images in Draw. So does it actually make sense to remove the panel there?
> If it doesn't work correctly, it's a different thing?

Oh, I learn something every day...

Multiple columns then make sense for images. 
What I see is that turning it on after typing multiple lines of text the beginning of the text gets positioned outside of the image area and disappears, but turning it off makes it visible again.

That's something different, let's keep this one focused on the media file part. Patch updated accordingly.
Comment 8 Commit Notification 2021-12-20 08:38:29 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/656ed2c6f217d73e4686726783dec5b940851daf

tdf#146311 Hide Columns section in sidebar

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2021-12-20 11:29:22 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/92536b0dab05c9dd42dd46e322057842d99c073d

tdf#146311 Hide Columns section in sidebar

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.