Bug 137245 - Image disappears after AutoFormat applies a paragraph border
Summary: Image disappears after AutoFormat applies a paragraph border
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.1.0 target:7.0.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-10-04 16:10 UTC by Radek Bezvoda
Modified: 2024-05-18 13:47 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Radek Bezvoda 2020-10-04 16:10:03 UTC
Description:
When creating a horizontal line after an image insertion, the line is created in the paragraph preceding the image, but the image itself is lost.

Steps to Reproduce:
1. In a new document, enter some text
2. Insert an image (Insert -> Image)
3. Write a few dashes and hit Enter
4. The horizontal line is created in the paragraph preceding the image, but the image itself is lost

Actual Results:
The horizontal line is created in the paragraph preceding the image, but the image itself is lost.

Expected Results:
Keep the image.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 6.4.6.2
Build ID: 1:6.4.6-0ubuntu0.20.04.1
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: cs-CZ (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Telesto 2020-10-05 06:54:01 UTC Comment hidden (obsolete)
Comment 2 V Stuart Foote 2020-10-07 14:12:09 UTC
Confirmed. Recent master Windows build.

Enabling and using the autocorrect [1] to 'Apply Border', as paragraph bottom border, is clobbering an image when anchored 'to character' or 'to paragraph'. Anchor 'to page' or 'as character' seems unaffected.

This seems a recent regression. 

=-ref-=

[1] https://help.libreoffice.org/7.1/en-US/text/shared/01/06040100.html?&DbPAR=WRITER&System=WIN
Comment 3 Aron Budea 2020-10-10 20:37:07 UTC
Bibisected to the 6.3 backport of the following commit using repo bibisect-linux-64-6.3. Adding CC: to Michael Stahl.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=28b77c89dfcafae82cf2a6d85731b643ff9290e5
author		Michael Stahl <Michael.Stahl@cib.de>	2019-07-11 18:37:28 +0200
committer	Michael Stahl <Michael.Stahl@cib.de>	2019-07-22 08:32:07 +0200

tdf#117185 tdf#110442 sw: bring harmony & peace to fly at-char selection
Comment 4 Commit Notification 2020-10-16 08:26:55 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9b34dc20b6946698ae6ce2d5d859885bfb444633

tdf#137245 sw: fix AutoFormat SetBorder deleting flys

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Michael Stahl (allotropia) 2020-10-16 08:27:17 UTC
fixed on master
Comment 6 Commit Notification 2020-10-16 12:15:06 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/3f554879aa90a73940041e3a1217b97a15e18bc3

tdf#137245 sw: fix AutoFormat SetBorder deleting flys

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Radek Bezvoda 2020-10-18 15:34:06 UTC
Fixed for me on 7.1 alpha build. Thanks for your great response!
Comment 8 Aron Budea 2020-10-18 16:27:19 UTC
Thanks for retesting, setting to VERIFIED.