Bug 114287 - fo:text-indent and fo:margin-left from paragraph style has to overrule those from list style
Summary: fo:text-indent and fo:margin-left from paragraph style has to overrule those ...
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL: http://docs.oasis-open.org/office/v1....
Whiteboard: odf target:7.6.0 target:24.8.0 target...
Keywords:
Depends on:
Blocks: 92762 ODF-import 78175 145318
  Show dependency treegraph
 
Reported: 2017-12-06 17:19 UTC by Regina Henschel
Modified: 2024-05-07 08:17 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
First part only paragraph indent, second part numbering added, third part combined (12.95 KB, application/vnd.oasis.opendocument.text)
2017-12-06 17:19 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2017-12-06 17:19:25 UTC
Created attachment 138251 [details]
First part only paragraph indent, second part numbering added, third part combined

Paragraphs style settings for fo:text-indent and fo:margin-left has to overrule those from the list style, read section 17.20 in the spec. But LibreOffice ignores the settings in the paragraph style, in case the numbering style is not referenced in the same <style:style> element, which defines the paragraph indents.

LibreOffice behavior of ignoring the settings in the paragraph style also effects the indent after setting as reported in bug 83532 and bug 108718.
Comment 1 Buovjaga 2017-12-17 16:48:58 UTC
Let's just set to NEW :)
Comment 2 QA Administrators 2019-04-05 02:59:22 UTC Comment hidden (obsolete)
Comment 3 Regina Henschel 2020-09-11 20:22:41 UTC
Still a problem, if fo:margin-left and fo:text-indent not directly in the automatic paragraph style, which has the style:list-style-name attribute, but is inherit from a custom style.

Tested with Version: 7.0.0.2 (x64)
Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL
Comment 4 Commit Notification 2023-02-28 15:44:14 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ade0a153f453500f15343380ac937252992733e0

tdf#114287 xmloff: ODF import: fix text:list override of list style

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 bugzilla 2024-03-06 22:08:31 UTC
This is a disaster.  See Bug 159366 and Bug 159972 for consequences.
Also https://ask.libreoffice.org/t/lists-behavior-from-writer-v-7-5-to-7-6-and-24-2/102976
Comment 6 Commit Notification 2024-04-26 11:09:09 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/546741148863ae0b2a25cc994a7323c8113cb573

tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2024-04-29 19:05:18 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/0c1e01cd8370b1c05e12dc965bf3e95bc2fd7378

tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override

It will be available in 7.6.8.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-04-29 19:15:30 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/d45a0651990a58b8eb1306205cb2209d1012398f

tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Michael Stahl (allotropia) 2024-04-30 17:13:02 UTC
1. the bug in the description, we already concluded last year that it's a bad idea to fix it because it would break interop with other ODF applications like Word

2. the bug that the commits were about is a different bug best described by https://bugs.documentfoundation.org/show_bug.cgi?id=156146#c3 but now it turned out that fixing that is also a bad idea; it would improve interop with Word, but break other things and it turns out that Word can't even roundtrip this thing itself
Comment 10 Commit Notification 2024-05-07 08:17:14 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-6-7":

https://git.libreoffice.org/core/commit/4f0f64820a2bdf5bdf9e6cf5ee83b38f87a65cbe

tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override

It will be available in 7.6.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.