Bug 160829

Summary:	checkbox state ticked / unticked poorly visible in dark mode (Breeze icon theme)
Product:	LibreOffice	Reporter:	steve <lo>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	normal	CC:	stephane.guillou, vsfoote
Priority:	medium	Keywords:	accessibility
Version:	24.8.0.0 alpha0+ Master
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=160830
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	107139, 107742, 153293
Attachments:	2024-04-26 check box state ticked and unticked in dark mode checkboxes test file

Description steve 2024-04-26 11:02:43 UTC

Description:
Checkbox state is hard to see in dark mode.

Steps to Reproduce:
1. add checkbox by opening View > Toolbars > Form Controls
2. select checkbox
3. draw an area in the writer document to add checkbox 🤯
4. make sure you are in correct mode (i.e. not in design mode) and tick the checkbox

Actual Results:
The state whether a checkbox is ticked or not is barely visible.

Expected Results:
We need contrast to be able to see UI elements (https://contrastrebellion.com/).


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d4f6534e8870e8f271984c37ce54a6878f372ae1
CPU threads: 4; OS: macOS 14.4.1; UI render: Skia/Raster; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Comment 1 steve 2024-04-26 11:03:47 UTC

Created attachment 193862 [details]
2024-04-26 check box state ticked and unticked in dark mode

Comment 2 steve 2024-04-26 11:04:04 UTC

Created attachment 193863 [details]
checkboxes test file

Comment 3 V Stuart Foote 2024-04-27 11:49:38 UTC

Can't confirm on Windows

Comment 4 V Stuart Foote 2024-04-27 13:31:09 UTC

When as for see also bug 160830 I toggle Options -> Application colors from Light to Dark, making document canvas dark. The icons for the Checkbox form controls toggle to dark mode, white fg check on a dark bg box.

The icons for form controls seem to follow the fg/bg adjustment, but need the icon theme to track. In Windows it does, maybe not in macOS?

Comment 5 Stéphane Guillou (stragu) 2024-05-13 01:10:17 UTC

Looks like it is specific to the Breeze (dark) icon theme.
Not reproduced with other icon theme variants. Steve, can you please double-check that's correct?
(You might need to restart LO to make extra sure the change of icon theme is registered, I have seen inconsistency in that.)

I can reproduce on Linux, so not macOS-specific.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ad1f0bdeac30fca1dc56a08803ef23f2aca4db05
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Comment 6 steve 2024-05-13 11:41:04 UTC

œStragu: interesting finding which I confirm.

Not OK:
- Breeze SVG + Dark
- 

OK
- Automatic (Sukapura (SVG - Dark))
- Colibre SVG Dark
- Sifr SFV + Dark

Did not test Elementary and Karasa Jaga as those do not have dark support and should probably be considered incomplete / moved to extension.