| Summary: | Shadow and image fill does not work together in presentation mode | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Regina Henschel <rb.henschel> |
| Component: | Impress | Assignee: | Armin Le Grand <Armin.Le.Grand> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | Armin.Le.Grand, kelemeng, quikee, raal, rafael.palma.lima, telesto |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.5.0.0 alpha0+ | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=151831 https://bugs.documentfoundation.org/show_bug.cgi?id=158298 |
||
| Whiteboard: | target:7.5.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103610 | ||
| Attachments: | Examples for the problem | ||
|
Description
Regina Henschel
2022-09-21 11:40:50 UTC
Repro with: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 35702fd6781542f5eefbd3710304ab9a25ac61fe CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL threaded I see the following issues: Slide 1: The shadow is a copy of the colored text (should be white) Slide 2: all ok Slide 3: all ok Slide 4: all ok Slide 5: same problem as slide 1 I'm setting this to NEW. However this seems to be a regression. It is NOT REPRO with: Version: 7.4.1.2 / LibreOffice Community Build ID: 40(Build:2) CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.4.1~rc2-0ubuntu0.22.04.1~lo1 Calc: threaded This seems to have begun at the below commit. Adding Cc: to Armin Le Grand; Could you possibly take a look at this one? Thanks 24bd024cb85b7d5ab151e8dec8be23afdbaf51c2 is the first bad commit commit 24bd024cb85b7d5ab151e8dec8be23afdbaf51c2 Author: Jenkins Build User <tdf@pollux.tdf> Date: Wed Sep 14 10:04:13 2022 +0200 source e735ad1c57cddaf17d6ffc0cf15b5e14fa63c4ad https://git.libreoffice.org/core/+/e735ad1c57cddaf17d6ffc0cf15b5e14fa63c4ad Took a look. I have a suspicion already, the former used processPrimitive2DOnPixelProcessor was always used for PRIMITIVE2D_ID_SHADOWPRIMITIVE2D, so *always* a BitmapEx was created as shadow. With that change for ShadowPrimitive2D the vector graphics representation is used again (better than pixel). Again because that was used before those glow things (including ShadowPrimitive2D) were added. That had worked in the past, so there must be a reason it does no longer. Looking for that... Ah, in VclMetafileProcessor2D::processPolyPolygonGraphicPrimitive2D taking care of maBColorModifierStack is missing. Was that removed...? It was changed by 9e2a9f4151babc6cb22553798ee70f7f623924db. Handling BColorModifierStack is missing in VclMetafileProcessor2D::processPolyPolygonGraphicPrimitive2D when creating the SvtGraphicFill information for the metafile. Possible solution at https://gerrit.libreoffice.org/c/core/+/140550 Armin Le Grand (allotropia) committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a96c9d7c5bb1ca6eaf72da49e29489f0f0ab1545 tdf#151104 correct missing ColorModification It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |