| Summary: | UNO command to show/hide the track changes toolbar | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Yousuf Philips (jay) (retired) <philipz85> |
| Component: | Writer | Assignee: | Gülşah Köse <gulsah.1004> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | gulsah.1004, h3734236, momonasmon, philipz85 |
| Priority: | medium | ||
| Version: | 4.5.0.0.alpha0+ Master | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=114644 | ||
| Whiteboard: | target:5.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 83946, 86899 | ||
| Attachments: | dimmed button | ||
|
Description
Yousuf Philips (jay) (retired)
2015-03-24 06:17:27 UTC
The uno command should be labelled as TrackChagesBar. I have added an icon for it. https://gerrit.libreoffice.org/14980 Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9006b8b1b3ce713d87b0ab90aec43ef0b0555e88 tdf#90187 icon for track changes toolbar button and sidebar It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Can you describe the work. Which changes should be track? (In reply to Gülşah Köse from comment #3) > Can you describe the work. Which changes should be track? No changes should be tracked. The UNO command should show or hide the track changes toolbar which is found in View > Tooolbars > Track Changes. Thank you. I am going to try to fix it. Created attachment 121699 [details] dimmed button I've sent this patch https://gerrit.libreoffice.org/21064 . But the track changes bar button seem dimmed. Can anyone help me? Gulsah Kose committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1949cc74b929e13799686b22b450ded8dbf4c064 tdf#90187 Added uno command for track changes bar. It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks Gulsah for the patch, but unfortunately it doesnt work when .uno:TrackChangesBar is added to the menu, which was one of the main points of having the UNO command. Is this something you can fix? (In reply to Yousuf (Jay) Philips from comment #8) >it doesnt work when >.uno:TrackChangesBar is added to the menu, which was one of the main points > of having the UNO command. Is this something you can fix? Jay, I couldn't understand the problem. Which menu and how you add there? (In reply to Yousuf (Jay) Philips from comment #8) > Thanks Gulsah for the patch, but unfortunately it doesnt work when > .uno:TrackChangesBar is added to the menu, The same way that .uno:InsertDraw doesn't work in a menu ( .uno:TrackChangesBar is sharing the same code with .uno:InsertDraw now). The only way to "fix" it is to throw out everything, and implement from scratch. Implementing show/hide functions shouldn't be that hard, but implement the correct checked/unchecked state isn't trivial I believe. |