Bug 64088

Summary: Reuse Recent Documents code in the Start Center
Product: LibreOffice Reporter: Jan Holesovsky <kendy>
Component: UIAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: robinson.libreoffice, vsfoote
Priority: medium Keywords: difficultyInteresting, easyHack, skillCpp
Version: 4.1.0.0.alpha0+ Master   
Hardware: Other   
OS: All   
See Also: https://bugs.freedesktop.org/show_bug.cgi?id=61174
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 61914    

Description Jan Holesovsky 2013-04-30 13:38:16 UTC 
The Start Center constructs the Recent Documents menu in BackingWindow::prepareRecentFileMenu():

http://cgit.freedesktop.org/libreoffice/core/tree/framework/source/services/backingwindow.cxx#n283

But this is effectively duplicating code (AKA copy'n'paste) from elsewhere, which causes that it lacks the nice 'Clear List' feature.  It would be much better to re-use the code, like in SfxRecentFilesToolBoxControl::CreatePopupWindow():

http://cgit.freedesktop.org/libreoffice/core/tree/sfx2/source/toolbox/tbxitem.cxx#n1761

To do this, you want to change the ActivateHdl link:

http://cgit.freedesktop.org/libreoffice/core/tree/framework/source/services/backingwindow.cxx#n970

to do the same thing as SfxRecentFilesToolBoxControl::CreatePopupWindow(), and remove all unnecessary pieces like prepareRecentFileMenu, maRecentFiles, etc. etc.

Should be straightforward, but in case you have problems, please ask :-)
Comment 1 Krisztian Pinter 2013-05-02 12:10:51 UTC 
I'm about to spend the following 2 weeks on this.
Comment 2 Jan Holesovsky 2013-05-28 19:45:24 UTC 
This has been sorted out by

http://cgit.freedesktop.org/libreoffice/core/commit/?id=174e32567f410e9049e9856629896ae6a798d752

in the meantime
Comment 3 Robinson Tryon (qubit) 2015-12-16 00:20:42 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyInteresting SkillCpp)
[NinjaEdit]