Summary: | When selecting an alternative link target for an OLE object, button says "Insert" | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Eyal Rozenberg <eyalroz1> |
Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | minor | CC: | heiko.tietze, stephane.guillou |
Priority: | low | Keywords: | needsDevEval |
Version: | 24.8.0.0 alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=157881 | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 107810, 112581 | ||
Attachments: | Screenshot of the "Edit Links" dialog |
Description
Eyal Rozenberg
2024-05-06 09:43:53 UTC
(In reply to Eyal Rozenberg from comment #0) > 5. Press "Modify" Where? I have Edit (opens the object), Properties, Delete, and Rename. Created attachment 193988 [details]
Screenshot of the "Edit Links" dialog
(In reply to Heiko Tietze from comment #1) > Where? I have Edit (opens the object), Properties, Delete, and Rename. Have a look at the screenshot. Edit > External Links... has a Modify button. (In reply to Eyal Rozenberg from comment #0) > Easy hack? Don't spot the string in a quick glance in ChangeSourceClickHdl at cui/source/dialogs/linkdlg.cxx. Maybe mxFileDlg->setTitle( SfxResId( STR_SFX_EXPLORERFILE_INSERT ) ); in sfx2/source/dialog/filedlghelper.cxx but this affects all dialogs then. Could be solved by introducing another flag for FileDialogFlags but using this flag becomes a bit tricky. (In reply to Heiko Tietze from comment #4) > Don't spot the string in a quick glance in ChangeSourceClickHdl at > cui/source/dialogs/linkdlg.cxx. Maybe mxFileDlg->setTitle( SfxResId( > STR_SFX_EXPLORERFILE_INSERT ) ); in sfx2/source/dialog/filedlghelper.cxx but > this affects all dialogs then. Could be solved by introducing another flag > for FileDialogFlags but using this flag becomes a bit tricky. But surely the button text is set differently for different file selection dialogs? Open, Save, Select, Insert ... Reproduced: Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: ae798781ef4df7a1fdef13af0bc459bf4f6e7b4c CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded Same with gen VCL plugin. Could be improved, but it's a fairly minor issue, as it's still understandable in the context of the linking. (I actually remember coming across another case where that button label doesn't match the action, and it being more jarring, but can't remember where...) |