Bug 160733

Summary: Change master slides copies the master slide multiple times
Product: LibreOffice Reporter: Gabor Kelemen (allotropia) <kelemeng>
Component: ImpressAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: stephane.guillou
Priority: medium Keywords: implementationError
Version: 6.3.0.4 release   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 108392    
Attachments: Example file with all slides master replaced
List of master slides after changing all slides' masters

Description Gabor Kelemen (allotropia) 2024-04-19 13:31:22 UTC 
Created attachment 193757 [details]
Example file with all slides master replaced

When the Change Master slide command is used on multiple selected slides, the new master slide is copied over multiple times to the target slideshow, making the file grow unnecessarily.

1. Create a new slideshow from the Candy template
2. Select all slides in the left Slides pane
3. Chosse Slide - Change Slide Master
4. Press Load
5. From the Presentations category select Beehive, press OK
6. Select the Beehive1 template from the two imported ones, OK
7. Go to the Master slides view
-> there are as many instances of the Beehive1 master slide, as there were slides selected in step 2. In case of the Candy template, that's 13 - adding to the file size unnecessarily.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cb4698626f17e005c820a7138c63a03c21120ecd
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

and all the way back to 6.3 when this Change Slide Master command first appeared in the menu.
Comment 1 Gabor Kelemen (allotropia) 2024-04-19 13:31:57 UTC 
Created attachment 193758 [details]
List of master slides after changing all slides' masters
Comment 2 Stéphane Guillou (stragu) 2024-05-28 08:04:16 UTC 
Reproduced in:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 101b08fe1ec77ffe8c1a9b2b8f9f20884269a1ed
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

(In reply to Gabor Kelemen (allotropia) from comment #0)
> and all the way back to 6.3 when this Change Slide Master command first
> appeared in the menu.
Assumed implementation error, then.