Summary: | Crash on save after deleting sheet | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Vlad-Mihai Sima <vladmihaisima> |
Component: | Calc | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | VERIFIED FIXED | ||
Severity: | critical | CC: | dennisfrancis.in, michael.meeks, miguelangelrv, raal, serval2412, stephane.guillou, telesto, vladmihaisima |
Priority: | medium | Keywords: | bibisected, bisected, haveBacktrace, regression |
Version: | 6.2.0.3 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=130435 | ||
Whiteboard: | target:24.8.0 target:24.2.3 | ||
Crash report or crash signature: | ["ScFormulaGroupCycleCheckGuard::ScFormulaGroupCycleCheckGuard(ScRecursionHelper&, ScFormulaCell*)","ScRecursionHelper::PushFormulaGroup"] | Regression By: | Dennis Francis |
Bug Depends on: | |||
Bug Blocks: | 107943, 108912, 133092 | ||
Attachments: |
Spreadsheet that crashes if one sheet except PROBLEM is deleted and file saved
gdb trace bt with console logs |
Description
Vlad-Mihai Sima
2024-03-25 23:10:46 UTC
Created attachment 193305 [details]
gdb trace
Confirm Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b38974391e8d4bf0d450abfaa86bbccbe1022995 CPU threads: 8; OS: macOS 14.3; UI render: Skia/Raster; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded Not reproducible: Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded neither with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1344e6261a1d856c71eca1e0cc29215a586bf335 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Thank you for reporting the bug. I can confirm that the bug is present in Version: 24.2.1.2 (X86_64) / LibreOffice Community Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded as well as Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a2265e8faa099d9652efd12392c2877c2df1d1eb CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Not reproduced without 'Force Skia software rendering' Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1344e6261a1d856c71eca1e0cc29215a586bf335 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Not reproduced without 'Skia' Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1344e6261a1d856c71eca1e0cc29215a586bf335 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Reproduced with: - 6.2.0.3, with "ScRecursionHelper::PushFormulaGroup": https://crashreport.libreoffice.org/stats/crash_details/b3abd5d1-0599-4ecf-93aa-4e6fdaadb61c - 7.0.0.3, same: https://crashreport.libreoffice.org/stats/crash_details/a46f2520-7b8a-4a53-b1db-b5864c58e658 - 7.3.0.3, with signature "ScFormulaGroupCycleCheckGuard::ScFormulaGroupCycleCheckGuard(ScRecursionHelper&, ScFormulaCell*)": https://crashreport.libreoffice.org/stats/crash_details/693cd29c-7efa-46fb-986f-e9af472bb229 - 7.6.5.2, same: https://crashreport.libreoffice.org/stats/crash_details/ffe18139-799b-4745-b4dd-b3fee563fe59 And recent trunk build: Version: 24.2.2.1 (X86_64) / LibreOffice Community Build ID: bf759d854b5ab45b6ef0bfd22e51c6dc4fb8b882 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded No repro in 6.1.0.3 -> regression. This seems to have begun at the below commit in bibisect repository/OS bibisect-linux-64-6.2. Adding Cc: to Dennis Francis ; Could you possibly take a look at this one? Thanks e6038449324f806a26398b9b63306624158ade7a is the first bad commit commit e6038449324f806a26398b9b63306624158ade7a Author: Jenkins Build User <tdf@pollux.tdf> Date: Fri Jul 6 14:28:17 2018 +0200 source 0f95580d392bb1a6f103f3a1543fb61a16f9f263 57004: Use cycle guard for calls to InterpretTail too | https://gerrit.libreoffice.org/c/core/+/57004 Created attachment 193320 [details]
bt with console logs
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Michael: thought you might be interested in this one as the reviewer of the quoted patch (see comment 7) Using data, calculate, recalculate hard also reproduces the underlying issue (with an assert in dbgutil mode at least) and is an easier problem to trace https://gerrit.libreoffice.org/c/core/+/165510 makes this work Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/18d0b7ac865f8d905a8b9afbe56677c89b1f406c Resolves: tdf#160368 crash on save after deleting sheet It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. merged to trunk now, backport to 24-2 in gerrit Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/85603be2365e80d3f8a363e99ac6196eb24d61c6 Resolves: tdf#160368 crash on save after deleting sheet It will be available in 24.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. On pc Debian x86-64 with master sources updated today, I don't reproduce this anymore. Thank you Caolán! :-) |