Bug 160276

Summary:	Writer comment: Author and Date info should use same padding as is used for comment text
Product:	LibreOffice	Reporter:	steve <lo>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	enhancement	CC:	heiko.tietze, mentoring, stephane.guillou
Priority:	low	Keywords:	difficultyBeginner, easyHack, skillCpp, topicDesign
Version:	24.8.0.0 alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=159531
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	106179
Attachments:	Screenshot 2024-03-19 Author and Date should use same padding as comment text screenshot with "reply to" header, and "resolved" status

Description steve 2024-03-19 14:04:55 UTC

Description:
Writer comment: Author and Date info should use same padding as is used for comment text

Steps to Reproduce:
Create a comment in writer.

Actual Results:
Author and Timestamp are stuck to the left boarder of the comment field.

Expected Results:
Author and Timestamp should use same padding as is used for the comment text.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 479b5bbe8ca2177ba7574e7aa2308b5d0de1895c
CPU threads: 8; OS: macOS 13.6.5; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Comment 1 steve 2024-03-19 14:05:12 UTC

Created attachment 193195 [details]
Screenshot 2024-03-19 Author and Date should use same padding as comment text

Comment 2 Stéphane Guillou (stragu) 2024-04-04 03:26:51 UTC

OOo 3.3 and 24.2.2.2 have both flush to the left border.
Padding was added by 1dc0c8c8304ebbce0a2e05e89a3b5458d88f3630 for bug 159531 
(should have looked at the "see also" before bibisecting, but I was mislead by the 3.3 as earliest version affected 😅)

Heiko says in bug 159531 comment 9:
> Different code, probably not easy to find. Having the author information drawn differently to the content is not bad (although spacing is our friend).

Note that the "Reply to" header has the same padding as the comment.

I agree that the spacing of the authorship info could be improved, it feels too close to the edge now that everything else is spaced. And there is no extra space between text and authorship info.

More opinion from other UX/Design contributors?

Comment 3 Stéphane Guillou (stragu) 2024-04-04 03:28:27 UTC

Created attachment 193477 [details]
screenshot with "reply to" header, and "resolved" status

Comment 4 Heiko Tietze 2024-04-04 08:39:16 UTC

No objection to a few pixel whitespace. But as additional info these lines do not need to align with the actual comment and are less important.

Potential code pointer: SwAnnotationWin::DrawForPage() in sw/source/uibase/docvw/AnnotationWin2.cxx