Summary: | Crash on closing LibreOffice with certain content on the clipboard | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Telesto <telesto> |
Component: | Writer | Assignee: | Miklos Vajna <vmiklos> |
Status: | RESOLVED FIXED | ||
Severity: | critical | CC: | aron.budea, buzea.bogdan, miguelangelrv, serval2412, stephane.guillou, vmiklos |
Priority: | medium | Keywords: | bibisected, haveBacktrace, regression |
Version: | 7.6.0.0 alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=124647 | ||
Whiteboard: | target:24.8.0 target:24.2.4 | ||
Crash report or crash signature: | ["SwHTMLWriter::GetCSS1Selector(SwFormat const *,rtl::OString &,rtl::OUString &,unsigned short &,rtl::OUString *)"] | Regression By: | Miklos Vajna |
Bug Depends on: | |||
Bug Blocks: | 108843, 133092, 145593 | ||
Attachments: |
Sample
dmp file bt |
Description
Telesto
2024-02-11 18:25:26 UTC
Created attachment 192508 [details]
Sample
No crash in Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: c170d1364be56d91fd16f255ffdc406b8e822732 CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Created attachment 192509 [details] dmp file With debug version Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2cedb1a19ad605df4e148589e9027512e4dd9265 CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded I get this at step: Ctrl+A warn:desktop:483957:483957:desktop/source/app/crashreport.cxx:61: minidump generated: /home/bogdan/.config/libreofficedev/4/crash//49730bf4-5d95-4aed-9007b8ac-65d9beac.dmp FWIW: I forgot to mention bug 124647 which is using the same file for a different crash (In reply to BogdanB from comment #2) > No crash in > Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: c170d1364be56d91fd16f255ffdc406b8e822732 > CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 > Locale: ro-RO (ro_RO.UTF-8); UI: en-US > Calc: threaded I guess it's Windows only issue; clipboard handling is OS-specific. -- Comment 3 is likely something different or related to bug 124647 Reproducible Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 17fc445938dedb05125a6d6a5b4ce7f34ea95f59 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Enable skia doesn't solve the issue. Also with Ver 3.3 Aoo directly crash after open the file. Created attachment 192529 [details]
bt
On pc Debian x86-64 with master sources updated today, I got an assertion.
I noticed that if I wait a bit more once the file is opened (I mean until there's no extra log in console), I don't get the assertion.
No crash in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded However, crashed as described on Windows 11: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Crash report: https://crashreport.libreoffice.org/stats/crash_details/ddf410e0-0f9d-45a8-81a2-9e32f4f39844 As Telesto said, let's keep it Windows-specific. Also reproduced on 7.6.5.2 (win 11). (In reply to Stéphane Guillou (stragu) from comment #8) > As Telesto said, let's keep it Windows-specific. I was able to repro with: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 53c5d570cab036b23f4969b858a648c8f0c24f93 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-US (C.UTF-8); UI: en-US Calc: threaded So, not OS-specific. Not sure how to solve it either. Interesting lines of output: warn:sw.core:2542771:2542771:sw/source/core/attr/format.cxx:217: ~SwFormat: format still has clients on death, but parent format is missing: Character style warn:sw.core:2542771:2542771:sw/source/core/attr/calbck.cxx:155: lost a client of type: 18SwFormatCharFormat at 0x606000e6f258 still registered on type: 8SwModify at 0x613000207c40. warn:sw.core:2542771:2542771:sw/source/core/attr/calbck.cxx:155: lost a client of type: 18SwFormatCharFormat at 0x606000e6f3d8 still registered on type: 8SwModify at 0x613000207c40. warn:sw.core:2542771:2542771:sw/source/core/attr/calbck.cxx:155: lost a client of type: 18SwFormatCharFormat at 0x606000e92d18 still registered on type: 8SwModify at 0x613000207c40. warn:sw.core:2542771:2542771:sw/source/core/attr/calbck.cxx:155: lost a client of type: 18SwFormatCharFormat at 0x606000e91f98 still registered on type: 8SwModify at 0x613000207c40. It seems we can only crash it on Linux with a debug build (comment 3, comment 7, I assume comment 10 too, Matt?). That's the case on my end, only crashes with debug build: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a1a1d8edb9d4a62b747aa7069b3026e2ba75704d CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded --- On Windows 11, no crash in 7.5.0.3 -> regression. (In reply to Stéphane Guillou (stragu) from comment #11) > It seems we can only crash it on Linux with a debug build (comment 3, > comment 7, I assume comment 10 too, Matt?). Yes, that's correct. > On Windows 11, no crash in 7.5.0.3 -> regression. I bibisected this using win64-7.6 repo and got the following result: bad commit is c804c5354855188b5a37219cfe11dc079dc235f4 which is: Author: Miklos Vajna <vmiklos@collabora.com> Date: Fri Mar 10 13:36:37 2023 +0100 sw content control: fix lost properties on copy&paste Adding Miklos to CC I think what happens here (based on Julien's backtrace) is that we have an original document with char styles and we create a clipboard document, but the SwFormat instances in the clipboard document refer to char styles in the original document, so it's important the full SwDoc is only deleted once the clipboard document is deleted. Normally the SwView has a weak reference to these clipboard documents, so these transferable instances are disposed/invalidated by the time the original SwDoc gets deleted, but not in this case, because we have some kind of leak. It's not yet clear to me how the above commit changes anything in this mechanism, given that the failing assert is all around char styles and their usage, not around content control. Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/06aeb9c61d50bba7edafe17f9d3513af26b0782f tdf#159683 sw content controls, plain text: fix crash with the clipboard doc It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/32616609c788aa1cf0837af0f387390a23de1766 tdf#159683 sw content controls, plain text: fix crash with the clipboard doc It will be available in 24.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |