Summary: | Comments in Writer's margins should have some padding spacing to avoid text being flush to the edge | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Jeff Fortin Tam <nekohayo> |
Component: | Writer | Assignee: | Heiko Tietze <heiko.tietze> |
Status: | CLOSED FIXED | ||
Severity: | minor | CC: | heiko.tietze, lo, mentoring, rafael.palma.lima |
Priority: | medium | Keywords: | difficultyMedium, easyHack, skillCpp, topicDesign |
Version: | Inherited From OOo | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=160276 | ||
Whiteboard: | target:24.8.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 106179 | ||
Attachments: |
Screenshot and mockup (current vs proposed UX)
Screenshot 2024-02-08 |
Description
Jeff Fortin Tam
2024-02-02 18:07:19 UTC
Created attachment 192357 [details]
Screenshot and mockup (current vs proposed UX)
6 pixels to the edge (as shown in this mockup) would not be intrusive,
yet would make for a noticeable improvement in UX.
Some padding would be nice indeed. +1 from my side. Slight clarification: while, in the case of this screenshot, my padding simulation was roughly 6 pixels from the left edge, I realize now that from an implementation standpoint this probably needs to be defined as a percentage of the comment widget's width, rather than a hardcoded pixel size, because the comment widget's width scales with the document's based on the view's Zoom Factor; that said, my point overall remains :) With the new comment style it's pretty simple to change on the paragraph style. But I agree that we should add indentation before/after by default. In sw/source/core/doc/DocumentStylePoolManager.cxx the attribute for RES_POOLCOLL_COMMENT needs to be added. The prototype might come from RES_POOLCOLL_HTML_BLOCKQUOTE leftMargin/rightMargin. Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1dc0c8c8304ebbce0a2e05e89a3b5458d88f3630 Resolves tdf#159531 - Indentation and spacing for comments It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: aa6d11771d085803cdb811579f47debc30c4d94b CPU threads: 8; OS: macOS 13.6.4; UI render: Skia/Metal; VCL: osx Locale: en-US (en_DE.UTF-8); UI: en-US Calc: threaded verified, thanks Heiko for handling this so swiftly. Created attachment 192465 [details]
Screenshot 2024-02-08
Wondering, if author and timestamp should align and use the same padding space. There really seems no reason not to. Wdyt? (In reply to steve from comment #8) > Wdyt? Different code, probably not easy to find. Having the author information drawn differently to the content is not bad (although spacing is our friend). Insert a non-breaking space ( Ctrl+Shift+Space) before your comment text. This will add a little space between the comment icon and the text, improving readability. https://incrediboxgame.co/ Follow-up bug about using same padding for Author and Timestamp info than what is used for Comment Text: https://bugs.documentfoundation.org/show_bug.cgi?id=160276 |