Summary: | Crash in SwTextFrame::MapModelToView(SwTextNode const*, int) const after pasting table and navigating left in footnote | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Stéphane Guillou (stragu) <stephane.guillou> |
Component: | Writer | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
Status: | VERIFIED FIXED | ||
Severity: | critical | CC: | michael.stahl, serval2412, telesto |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 7.0.0.3 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=158740 https://bugs.documentfoundation.org/show_bug.cgi?id=130685 https://bugs.documentfoundation.org/show_bug.cgi?id=159026 https://bugs.documentfoundation.org/show_bug.cgi?id=159025 https://bugs.documentfoundation.org/show_bug.cgi?id=159664 https://bugs.documentfoundation.org/show_bug.cgi?id=160302 |
||
Whiteboard: | target:24.8.0 | ||
Crash report or crash signature: | ["SwTextFrame::MapModelToView(SwTextNode const*, int) const","SwTextFrame::MapModelToView"] | Regression By: | |
Bug Depends on: | |||
Bug Blocks: | 103164, 133092 | ||
Attachments: | sample ODT |
Description
Stéphane Guillou (stragu)
2024-01-04 17:10:33 UTC
Confirm Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: a9ad36ae46ff76c0d59b0d170314fdd3a9ee5d35 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded On pc Debian x86-64 with master sources updated today, I don't reproduce the crash. I was able to repro an assert firing at: SwTextFrame::MapModelToView(SwTextNode const*const pNode, sal_Int32 const nIndex) const Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 205dd919179f34815d7e16c8dc73d2a7efd34535 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded can't reproduce - i can't paste the table inside the footnote because table isn't allowed in footnote - i can paste the table at the start of the body paragraph that contains the footnote reference (in case that was intended), but then i don't get a crash moving the cursor. (In reply to Michael Stahl (allotropia) from comment #4) > can't reproduce - i can't paste the table inside the footnote because table > isn't allowed in footnote - i can paste the table at the start of the body > paragraph that contains the footnote reference (in case that was intended), > but then i don't get a crash moving the cursor. The table does not show either for me, but still it is a required step to then crash it. Does it not crash for you following exactly the steps in Description? Slightly confused: The steps are nearly identical as bug 159025 comment 6. So problem source might be the same Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4b68824d18316762a6afc35d355221e0228aebf8 tdf#159023 sw_redlinehide: fix layout frames copying table into footer It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. okay thanks not sure what i did, perhaps used the wrong cursor key :) turns out the table is in fact pasted, but as just 4 paragraphs, and the problem was that the layout frames for those paragraphs were not created. fixed on master next problem is that after pasting, Undo will crash with sw/source/core/txtnode/thints.cxx:1346: bool SwTextNode::InsertHint(SwTextAttr*, SetAttrMode): Assertion `pAttr && pAttr->GetStart() <= Len()' failed. apparently this is the crash that https://bugs.documentfoundation.org/show_bug.cgi?id=159025#c6 is about and it's a pre-existing one (can repro in LO 6.1) so should be tracked there, not here. Thank you Michael, I verified the fix in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d0dcd87788910e3c9f67a2b68534019c05b77bad CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded |