Summary: | FILEOPEN: DOCX: footer has text when it shouldn't | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Xisco Faulí <xiscofauli> |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | normal | CC: | aron.budea, buzea.bogdan, quikee, vmiklos, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 24.2.0.0 alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=158814 | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | Tomaž Vajngerl | |
Bug Depends on: | |||
Bug Blocks: | 104522, 161381 | ||
Attachments: | Comparsion MSO vs LibreOffice 24.8 master |
Description
Xisco Faulí
2024-01-02 15:59:58 UTC
Regression introduced by: author Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> 2023-11-28 13:46:21 +0900 committer Tomaž Vajngerl <quikee@gmail.com> 2023-12-01 08:26:38 +0100 commit 4b0fa253a4540f5461397815d290586f9ddabe61 (patch) tree c58c59871244dc75e538caeea40658303da00b8b parent 93357349ff1998b41ea1ebedf09dc1cc5da316f7 (diff) tdf#136472 adjust ooxml import to handle first header/footer Bisected with: bibisect-linux64-24.2 attachment 92600 [details] from bug 59884 is also affected by this issue (In reply to Xisco Faulí from comment #1) > Regression introduced by: > > author Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> 2023-11-28 13:46:21 > +0900 > committer Tomaž Vajngerl <quikee@gmail.com> 2023-12-01 08:26:38 +0100 > commit 4b0fa253a4540f5461397815d290586f9ddabe61 (patch) > tree c58c59871244dc75e538caeea40658303da00b8b > parent 93357349ff1998b41ea1ebedf09dc1cc5da316f7 (diff) > tdf#136472 adjust ooxml import to handle first header/footer > > Bisected with: bibisect-linux64-24.2 Hi Tomaz, Miklos, Looking at the above commit, I see at least 10 tests that were commented out with the comment TODO to make Jenkins happy and be able to submit the patch, which looks like a quite bad practice to me. Is there any plan from your side to fix those existing tests that were commented out ? https://gerrit.libreoffice.org/c/core/+/162992 restores one of those disabled tests. Once that's in, let's see if the others can be restored in similar ways. (In reply to Miklos Vajna from comment #4) > https://gerrit.libreoffice.org/c/core/+/162992 restores one of those > disabled tests. Once that's in, let's see if the others can be restored in > similar ways. Thanks a lot for looking into it |