Bug 158343

Summary:	FILEOPEN DOCX Crash on opening file
Product:	LibreOffice	Reporter:	Gabor Kelemen (allotropia) <kelemeng>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	79045_79045, stephane.guillou, Tex2002ans+LibreOffice, vmiklos
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	24.2.0.0 alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=158344
Whiteboard:
Crash report or crash signature:	["SwTabFrame::MakeAll(OutputDevice)","SwTabFrame::MakeAll(OutputDevice )"]	Regression By:
Bug Depends on:
Bug Blocks:	133092
Attachments:	Example file from Word 2016

Description Gabor Kelemen (allotropia) 2023-11-23 22:08:13 UTC

Created attachment 191005 [details]
Example file from Word 2016

Attached example file crashes LO when opened.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9602f8a9318dd4d3409856e2ae06abe96e72b51b
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Seems to have started with:

https://git.libreoffice.org/core/+/9057641f678b8e36c9dbc41960b182c6ecfdda15

author	Khaled Hosny <khaled@libreoffice.org>	Wed Jul 19 05:53:09 2023 +0300
committer	خالد حسني <khaled@libreoffice.org>	Sun Jul 23 06:03:29 2023 +0200

vcl: SalLayout::GetTextWidth() returns double

Comment 1 Stéphane Guillou (stragu) 2023-11-24 13:00:22 UTC

On Linux, crash with:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7d357628d6e8ce3f9e3c3a567ada21f02bce8d42
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US

But also with 7.6.3.2:

Version: 7.6.3.2 (X86_64) / LibreOffice Community
Build ID: 29d686fea9f6705b262d369fede658f824154cc0
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US

No crash in 7.5.8:

Version: 7.5.8.2 (X86_64) / LibreOffice Community
Build ID: f718d63693263970429a68f568db6046aaa9df01
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US

I get the same SwTabFrame::MakeAll(OutputDevice*) signature as for bug 158344: https://crashreport.libreoffice.org/stats/crash_details/8c1dc28f-0e25-4921-8ee9-69a99a299a54

Indeed, I checked before and after Khaled's 9057641f678b8e36c9dbc41960b182c6ecfdda15: I don't get a crash, only a hang.
The crash starts with Michael's 8c24bc5baa1f501943bf955e07787d80cb7a5763.

Maybe different on Windows?

Comment 2 Roman Kuznetsov 2023-11-24 14:21:08 UTC

NEW by Comment 1

Comment 3 Tex2002ans 2024-02-16 21:58:40 UTC

Here's a CRASH on Windows 11:

- https://crashreport.libreoffice.org/stats/crash_details/75573558-a5e5-48c0-b655-f1b2945c271a

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Comment 4 Tex2002ans 2024-02-16 22:03:24 UTC

Stéphane, I also looked close at the crash report you linked in comment 1...

Yours seems to have:

- SwTabFrame::MakeAll(OutputDevice*)

where mine just had:

- SwTabFrame::MakeAll(OutputDevice *)

(Notice the SPACE before the asterisk.)

Hmm... wonder if that's relevant at all too?

Comment 5 Gabor Kelemen (allotropia) 2024-03-08 20:40:16 UTC

This seems to be fixed in master since:

https://git.libreoffice.org/core/+/186de7178c6065e1de13fd216b46ac9b716e44c5

author	Miklos Vajna <vmiklos@collabora.com>	Thu Feb 29 08:17:41 2024 +0100
committer	Miklos Vajna <vmiklos@collabora.com>	Thu Feb 29 11:39:54 2024 +0100
tree c33dcbd5b761d1c1cf095918ae126c228f409227
parent 62f71496c9faf071ba838df1e5d0d7b1465ab839 [diff]

tdf#158801 sw floattable: fix crash with headers and interactive editing

Thanks Miklos :)

*** This bug has been marked as a duplicate of bug 158801 ***

Comment 6 Stéphane Guillou (stragu) 2024-03-12 11:50:26 UTC

(In reply to Tex2002ans from comment #4)
> Stéphane, I also looked close at the crash report you linked in comment 1...
> 
> Yours seems to have:
> 
> - SwTabFrame::MakeAll(OutputDevice*)
> 
> where mine just had:
> 
> - SwTabFrame::MakeAll(OutputDevice *)
I've seen this before, it's a slight difference between Linux and Windows crash signatures. Unfortunately, it means they are collected separately on our crash report website.