Summary: | CRASH when switch back from HTML View to Normal View after edit in HTML source code | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Rainer Bielefeld Retired <LibreOffice> |
Component: | Writer Web | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | critical | CC: | momonasmon, serval2412, stephane.guillou |
Priority: | medium | Keywords: | bibisected, bisected, haveBacktrace, regression |
Version: | 24.2.0.0 alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=103064 | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | Maxim Monastirsky | |
Bug Depends on: | |||
Bug Blocks: | 133092 | ||
Attachments: |
Sample Document
gdb bt |
Description
Rainer Bielefeld Retired
2023-11-22 16:12:26 UTC
Thank you for the report! (In reply to Rainer Bielefeld Retired from comment #0) > 1. Open sample document "own.HTML" > 2. HTM Source View I had to use the command "create HTML document" (.uno:NewHtmlDoc) before being able to use that source view (.uno:SourceView). Reproduced the crash: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 7d357628d6e8ce3f9e3c3a567ada21f02bce8d42 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Without sample doc: 1. Open Writer 2. File > New > HTML document 3. Write "Test" 4. Switch to Source View, save document as prompted 5. Remove "Test" from the source 6. Turn Source View off No repro in: Version: 7.6.3.1 (X86_64) / LibreOffice Community Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Bibisected with linux-64-24.2 repo to first bad build commit [867559232d567aefa2ba108a880f93431008ef2a] which points to: commit d934aeace6e7049db3959421538ae382cb97b1d1 author Maxim Monastirsky Thu Jun 15 11:16:18 2023 +0300 committer Maxim Monastirsky Fri Jun 16 00:48:44 2023 +0200 tdf#103064 sw,editeng: make para styles work inside comments Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153156 Maxim, can you please have a look? Created attachment 190990 [details]
gdb bt
On pc Debian x86-64 with master sources updated today, I could reproduce this.
I attached bt with gdb console logs if it can help.
I don't know if it's expected that GetStyleSheetPool may return null. If it is, this patch can fix this: diff --git a/sw/source/uibase/docvw/PostItMgr.cxx b/sw/source/uibase/docvw/PostItMgr.cxx index 12c5e4f52d11..c69402c8583e 100644 --- a/sw/source/uibase/docvw/PostItMgr.cxx +++ b/sw/source/uibase/docvw/PostItMgr.cxx @@ -225,7 +225,9 @@ SwPostItMgr::SwPostItMgr(SwView* pView) StartListening(*mpView->GetDocShell()); // listen to stylesheet pool to update on stylesheet rename, // as EditTextObject references styles by name. - StartListening(*static_cast<SwDocStyleSheetPool*>(mpView->GetDocShell()->GetStyleSheetPool())->GetEEStyleSheetPool()); + SfxStyleSheetBasePool* pPool = mpView->GetDocShell()->GetStyleSheetPool(); + if (pPool) + StartListening(*static_cast<SwDocStyleSheetPool*>(pPool)->GetEEStyleSheetPool()); if (!mvPostItFields.empty()) { mbWaitingForCalcRects = true; |