Summary: | Add an opportunity to hide sections via context menu at the Navigator | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Roman Kuznetsov <79045_79045> |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | 79045_79045, heiko.tietze, raykowj, stephane.guillou |
Priority: | medium | ||
Version: | Inherited From OOo | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:24.2.0 inReleaseNotes:24.2 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103030, 107738 | ||
Attachments: | Navigator Sections context menu protect and hide section demo |
Description
Roman Kuznetsov
2023-10-10 10:04:39 UTC
Jim and UX-team what do you think about it? (In reply to Roman Kuznetsov from comment #0) > Description: > Add an opportunity to hide any file (but not to delete it) in master > document like a slide in a presentation Hi Roman, The 'Edit link' popup menu item opens the 'Edit Section' dialog which gives the opportunity to hide sections. I suppose a 'Hide' check menu item could be added to the Navigator popup menu to bypass the need to open the dialog to hide a section. Let's see what the UX team thinks. To hide and to protect are the primary actions for a section. And it would be great to have contextual access to it from the Navigator. Created attachment 190914 [details] Navigator Sections context menu protect and hide section demo Here is link to a patch that adds protect and hide menu items to the Navigator Sections context menu: https://gerrit.libreoffice.org/c/core/+/159718 It also makes the same icons appear in the Navigator section entries list that are shown in the Edit Sections dialog sections list to indicate section protect and hide settings. (In reply to Jim Raykowski from comment #4) > Created attachment 190914 [details] > Navigator Sections context menu protect and hide section demo Great work. Unrelated issue: the sections hierarchy is indicated by the white space rather than a true indentation. Makes the inheritance a bit unclear, although for example the hidden attribute would need to be disabled so it can't be on/off independently from the parent. (In reply to Heiko Tietze from comment #5) > Great work. Unrelated issue: the sections hierarchy is indicated by the > white space rather than a true indentation. Makes the inheritance a bit > unclear, although for example the hidden attribute would need to be disabled > so it can't be on/off independently from the parent. A demo of true sections hierarchy can be see here: https://bugs.documentfoundation.org/attachment.cgi?id=190955 (In reply to Jim Raykowski from comment #6) > A demo of true sections hierarchy can be see here: Much better 👍 Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/01a02ee7f1dbe7501a89b41e62599fba6a8b33f3 tdf#157681 SwNavigator: Add Protect and Hide menu items to Sections It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Jim, your great patch works only for general Writer document, but it doesn't work in master document unfortunately. I checked in Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 0ddd9f7e055a0c1ecb120de3e40c3fdb8373e9dc CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL threaded Hi Roman, It seems to work the same as using the Edit Section dialog. Only sections that are file linked hold the protected and hidden settings for master documents. Sections inside a linked file don't/can't remember the protected and hidden settings when set from a master document. I think/guess because the master document is only able to view the content of linked files and not changed them directly. Let's keep as "fixed" then, and follow-up in different tickets if needed. Added to release notes: https://wiki.documentfoundation.org/index.php?title=ReleaseNotes%2F24.2&type=revision&diff=714941&oldid=712682 |