| Summary: | Preview in Spacing dialog does not respect dark mode | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Rafael Lima <rafael.palma.lima> |
| Component: | Formula Editor | Assignee: | Rizal Muttaqin <rizmut> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | rizmut, stephane.guillou |
| Priority: | medium | Keywords: | accessibility |
| Version: | 7.6.0.0 alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.6.0 target:7.5.4 target:24.8.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 106228, 107139, 125965, 131141, 153293 | ||
| Attachments: | Screenshot showing the problem | ||
The problem here is related to the available images in each icon theme. Each "preview" is actually a hardcoded image that depends on the current icon theme. For instance, the image in the screenshot is "dist11.png", which is not defined for Breeze dark (which is the theme I'm using). It's only defined for Colibre, Colibre dark and Karasa jaga. Since we already have light and dark variants for these images, We could simply copy them into the other icon themes. @Rizal, what's your opinion about this? Reproduced on Ubuntu 20.04 with GNOME 3.36.8 using gtk3, kf5 and qt5 VCLs. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1b06f35de68a555b85bceb5fc29d1a5f426f4bb7 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Same on macOS. Ah big thanks for this bug report. I am about to create the same report but always forgotten. Actually this is on my to do list. Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8505d29d61a76ffa506be0dc86fe2ec7ed647483 tdf#154774 Breeze: Add images for spacing preview in Math It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Rizal Muttaqin committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/6e0d4020836004d754950b34ac170ed7d24e6542 tdf#154774 Breeze: Add images for spacing preview in Math It will be available in 7.5.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/33a4a934a230c551d053c30938ec802b2924182b tdf#154774 Breeze & Sifr: Add image for spacing preview in Math It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Rizal Muttaqin committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/1e860ee6fe1a7b8cc141bda1106364d8ebb3f9b3 tdf#154774 Breeze & Sifr: Add image for spacing preview in Math It will be available in 7.5.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/398d64e32c60871315ca31524d7a204fb0576ebe tdf#154774 KJ & Sukapura: +/^ images for spacing preview in Math It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Rizal Muttaqin committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/98c95b65480c71d1fa0d3da1cdf68e13b73b6306 tdf#154774 KJ & Sukapura: +/^ images for spacing preview in Math It will be available in 7.5.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Rizal, was there more to do here? Testing with a recent trunk build: - Breeze (dark): OK - Colibre (dark): OK - Sifr (dark): text is light grey on dark grey background. Better than in 7.4, but still not enough contrast for the high contrast icon theme. - Sukapura (dark): OK So there is only Sifr left to fix? Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/32d8a539ced92168958a6b608708bd77a375ad9f tdf#154774 Sifr: Adjust contrast for dark variant It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Looking good in own build: Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: b860aea9d6f8ac46f6d2575ead25337495ec9a88 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded Thanks Rizal! :) |
Created attachment 186618 [details] Screenshot showing the problem In Math, the preview in the Spacing dialog does not respect dark mode. Steps to reproduce: 1) Open Math (make sure you're using dark mode) 2) Go to Format - Spacing 3) Notice that the preview in the right uses dark color over dark background System info Version: 7.5.2.2 (X86_64) / LibreOffice Community Build ID: 50(Build:2) CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 4:7.5.2~rc2-0ubuntu0.22.10.1~lo1 Calc: threaded