Bug 154550

Summary:	add icon for Edit Index Entry for Colibre, Sukapura, Breeze, and Sifr
Product:	LibreOffice	Reporter:	sdc.blanco
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	enhancement	CC:	rizmut, stephane.guillou
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=153892 https://bugs.documentfoundation.org/show_bug.cgi?id=153847
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	106228

Description sdc.blanco 2023-04-01 23:32:43 UTC

As part of bug 153847, .uno:IndexEntryDialog will get a popup label of "Edit Index Entry". At present, this .uno does not have an icon.  It would look better if there was an icon.  To see its context: Insert or use an existing index entry, place cursor in index entry, and right-click. (at present, it will appear as "Index Entry", but soon it will be "Edit Index Entry").

If changes are made to "Insert Index Entry" (in connection with bug 153892), then it would make sense to use the same icon, but with the "pencil" in the lower right corner (to signify "edit").

Comment 1 Stéphane Guillou (stragu) 2023-04-18 09:28:25 UTC

Using the Tools > Customize dialog and searching for the command, I can already see an icon (tested with Elementary icon set), in both 7.6 and 7.5.
It is not displayed in the context menu for some VCLs (e.g. GTK3) but I can see it used currently with the KF5 VCL (as I understand it, visibility of icons in the context menu depend on what desktop environment the VCL mainly caters for).

- .uno:InsertIndexesEntry and .uno:IndexEntryDialog have the same icon.
- .uno:EditCurIndex uses that icon with a pencil icon overlaid.

Which VCL do you use?

Comment 2 sdc.blanco 2023-04-20 02:59:11 UTC

(In reply to Stéphane Guillou (stragu) from comment #1)
> Using the Tools > Customize dialog and searching for the command,
search on:  Index entry
will give the two relevant .unos.

> - .uno:InsertIndexesEntry and .uno:IndexEntryDialog have the same icon.
Repro when using "Elementary" icon theme (i.e., both have the same same icon), and it also appears in the context menu.
But for Colibre icon theme, there is no icon for .uno:IndexEntryDialog

> - .uno:EditCurIndex uses that icon with a pencil icon overlaid.
Not relevant here.  That is for indexes.
 
> Which VCL do you use?
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc6806c4be8585ce0d35a6b581bf8b3dbf858500
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: af-ZA (da_DK); UI: en-US
Calc: CL threaded

Comment 3 Stéphane Guillou (stragu) 2023-04-27 12:48:37 UTC

OK, thanks Seth, confirmed for Colibre.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded