Summary: | crash / no effect when clicking some dropdown buttons when toolbar overflows | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Stéphane Guillou (stragu) <stephane.guillou> |
Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | VERIFIED FIXED | ||
Severity: | critical | CC: | caolan.mcnamara, contact, ilmari.lauhakangas, martin.sourada, md.ashikurrahmanasif, noelgrandin |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 7.4.4.2 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=152155 https://bugs.documentfoundation.org/show_bug.cgi?id=150380 https://bugs.documentfoundation.org/show_bug.cgi?id=157738 https://bugs.documentfoundation.org/show_bug.cgi?id=156820 https://bugs.documentfoundation.org/show_bug.cgi?id=141141 |
||
Whiteboard: | target:24.8.0 target:24.2.3 target:7.6.7 | ||
Crash report or crash signature: | Regression By: | Caolán McNamara | |
Bug Depends on: | |||
Bug Blocks: | 100156, 103182, 107237, 112974 | ||
Attachments: |
gdb backtrace with LO 7.6 alpha1+ debug, "no stack"
wayland debug log |
Description
Stéphane Guillou (stragu)
2023-03-08 15:11:19 UTC
I cannot reproduce the crash, but the dropdown buttons (e.g. border, color, currency) do nothing (just close the expanded panel) when they’re hidden. In 7.3 it works as expected, in 7.4 and 7.5 it's broken. Version: 7.5.0.1 (X86_64) / LibreOffice Community Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: cs-CZ Calc: threaded *** Bug 154079 has been marked as a duplicate of this bug. *** Confirmed via duplicate bug 154079. Seems to be Wayland-related? Clicked all the hidden split buttons, but no crash on Wayland + gtk3 However, I can't repro even with the blamed 288c0920a8475f9f2c537212e04aa7649192ad8c Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 79e60bb93f69370f23010adb078b5a5de5a1e7b2 CPU threads: 8; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Martin and Buovjaga, can you please try again with this modified step 3: 1. Open Calc 2. Resize window horizontally in order to hide the buttons up to (and including) the "Format as currency" button. 3. Click on the arrow next to "Border Color" I could still reproduce with a recent master build, but could not get it to crash with a debug build, and crash reporter does not pop up in any version tested. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ad5756f0529a80fbb537979bcfd9de7a83a69805 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded (In reply to Stéphane Guillou (stragu) from comment #5) > Martin and Buovjaga, can you please try again with this modified step 3: > > 1. Open Calc > 2. Resize window horizontally in order to hide the buttons up to (and > including) the "Format as currency" button. > 3. Click on the arrow next to "Border Color" > > I could still reproduce with a recent master build, but could not get it to > crash with a debug build, and crash reporter does not pop up in any version > tested. Works fine in a non-debug build under Wayland Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16 CPU threads: 8; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: CL threaded Created attachment 187898 [details] gdb backtrace with LO 7.6 alpha1+ debug, "no stack" I could crash a debug build using the steps in comment 3, but couldn't collect a trace. Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 7e3ddf1e5aae5e4e956495e3d86a8cbf6e251b5e CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded In the console I see: Gdk-Message: 23:37:44.155: Error 71 (Protocol error) dispatching to Wayland display. Created attachment 187899 [details] wayland debug log In a wayland debug log collected with: WAYLAND_DEBUG=1 libreofficedev7.6 >& lo-wayland-log.txt I can see: [3812106.409] wl_display@1.error(xdg_wm_base@24, 3, "Invalid popup parent window") This validation seems to have been added to mutter with: https://mail.gnome.org/archives/commits-list/2020-August/msg10980.html The commit message says it is a client error: "Calling `get_popup` on an unmapped window is a client bug, thus post a protocol error when this happens." *** Bug 156158 has been marked as a duplicate of this bug. *** I just ran into another way to crash it, here with the tabbed UI: Steps: 1. Open Draw with Tabbed UI 3. Reduce window size so the Line / Area controls in the Home tabs overflow 3. From the overflow, click the Line Style dropdown Results: - if you click on the down arrow, nothing happens. - if you click on the line preview, crash. No crash reporter. In console, same message: Gdk-Message: 09:53:12.267: Error 71 (Protocol error) dispatching to Wayland display. Started at same commit. Maybe these steps are more consistent and also crash for you, Buovjaga? (In reply to Stéphane Guillou (stragu) from comment #10) > I just ran into another way to crash it, here with the tabbed UI: > > Steps: > 1. Open Draw with Tabbed UI > 3. Reduce window size so the Line / Area controls in the Home tabs overflow > 3. From the overflow, click the Line Style dropdown > > Results: > - if you click on the down arrow, nothing happens. > - if you click on the line preview, crash. No crash reporter. > > In console, same message: > > Gdk-Message: 09:53:12.267: Error 71 (Protocol error) dispatching to Wayland > display. > > Started at same commit. > > Maybe these steps are more consistent and also crash for you, Buovjaga? No crash for me under Wayland. Clearly there is something different in our systems. Version: 7.6.5.0.0+ (X86_64) / LibreOffice Community Build ID: 30ee116ee498160a366a5a618649f832ae371f7d CPU threads: 8; OS: Linux 6.7; UI render: default; VCL: gtk3 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ef6083200a4f28e43198c7a0878da6f4b880725f CPU threads: 8; OS: Linux 6.7; UI render: default; VCL: gtk3 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bee080ab7ca21d05de0519361a19724ef609a86b Resolves: tdf#154072 no effect when clicking some dropdown buttons It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Don't know about the crash, but the non-functioning click should work in trunk now, can probably assume the crash is the same issue I guess. Backport to 24-2 in gerrit. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/f409cc5d0c671d0428f709523238f551f9a5fd69 Resolves: tdf#154072 no effect when clicking some dropdown buttons It will be available in 24.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks Caolán! Verified the fix in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 069bf61cea5e3aea07ffd5a1bb9f55324651cb35 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded No crash, but couldn't crash it anyway before the patch on Ubuntu 22.04 + GNOME 42.9. Crashes used to happen on Ubuntu 20.04 + GNOME 3.36(38?), so might have been tied to whatever GNOME + Wayland + mutter version combination from back then. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/508a755a465c322af3c08f871299ce57193ca523 Resolves: tdf#154072 no effect when clicking some dropdown buttons It will be available in 7.6.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |