Summary: | Document Recovery should not offer to recover read-only files | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | JindrichP. <jpachta> |
Component: | Calc | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED DUPLICATE | ||
Severity: | minor | CC: | ilmari.lauhakangas |
Priority: | medium | ||
Version: | 7.4.3.2 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | All | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: |
Description
JindrichP.
2023-01-21 09:10:26 UTC
Correction: yes, I can reproduce the behavior. Actually, recovery should simply not try to recover files that were open in read-only mode. Because it means there was no possible unsaved changes that need recovery. Note that recovery does not mean "recover last session", but "recover unsaved changes after a crash". I repro the recovery offering to recover the read-only file if there has also been a normal file at the time of crash, but it is opened in read-only mode. However, per Mike's suggestion it should not be on offer at all. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b5c3a7502f7ff6ccf0f829c1f3a2ba50b8584c41 CPU threads: 2; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_FI); UI: en-US Calc: threaded (In reply to Mike Kaganski from comment #2) > Actually, recovery should simply not try to recover files that were open in > read-only mode. Because it means there was no possible unsaved changes that > need recovery. What happens if a user initially opens in read-only mode but then activates edition? The file was originally opened as read-only, but it is editable by the time a crash happens. Should recovery be attempted on such file? *** This bug has been marked as a duplicate of bug 57414 *** (In reply to ady from comment #4) > (In reply to Mike Kaganski from comment #2) > > recovery should simply not try to recover files that were open in > > read-only mode. Because it means there was no possible unsaved changes that > > need recovery. > > What happens if a user initially opens in read-only mode but then activates > edition? The file was originally opened as read-only, but it is editable by > the time a crash happens. Should recovery be attempted on such file? Not "files that had been *opened* in read-only mode", but "files that were in read-only mode at the moment of crash". Basically - the fact of becoming read-only (even from an initially editable state) should remove the file from the set of files tracked for recovery. |