Summary: | Dashed edges in Impress slides are not visible in dark mode | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Rafael Lima <rafael.palma.lima> |
Component: | Impress | Assignee: | Rafael Lima <rafael.palma.lima> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caolan.mcnamara, lo, rizmut |
Priority: | medium | ||
Version: | 7.6.0.0 alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:7.6.0 target:7.5.1 target:7.5.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 118017 | ||
Attachments: |
Screenshot in light mode (OK)
Screenshot in dark mode (NOK) macOS 2022-12-22 Darkmode - Printscreen - Impress New screenshot showing the problem Screenshot of the proposed fix |
Description
Rafael Lima
2022-12-20 19:02:36 UTC
Created attachment 184275 [details]
Screenshot in dark mode (NOK)
WHile I can't confirm this on macOS (the dotted lines are there), they don't show great in dark mode since they display in dark grey on a light grey background. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2e8776c181d0e38a8d25481ac0eb33389940bf95 CPU threads: 8; OS: Mac OS X 13.1; UI render: Skia/Raster; VCL: osx Locale: de-DE (en_DE.UTF-8); UI: en-US Calc: threaded Created attachment 184309 [details]
macOS 2022-12-22
Created attachment 184685 [details]
Darkmode - Printscreen - Impress
Hello, I tried to repeat your bug on windows 10, Version: 7.4.3.2 (x64) / LibreOffice Community. And the bug is not present. I attached a document to illustrate it. Created attachment 184714 [details] New screenshot showing the problem (In reply to Sophie Sipasseuth from comment #4) > Created attachment 184685 [details] > Darkmode - Printscreen - Impress Hi Sophie, Note that the dashed lines in your screenshot are black over a dark background. These dashed lines should have better contrast. I took a screenshot of the file you've just attached and annotated where the bug is. Created attachment 184783 [details] Screenshot of the proposed fix Here's a patch proposed for this fix: https://gerrit.libreoffice.org/c/core/+/145800 The screenshot shows how it looks with the patch applied. Rafael Lima committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cd20a17ab703e97191b4e3421527267ef82a704f tdf#152622 Fix color of Object Boundaries in dark mode It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Rafael Lima committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/e6b93b66aee8184da05d7d45443693438f4d4eea tdf#152622 Fix color of Object Boundaries in dark mode It will be available in 7.5.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Sorry a little bit out of topic. IMHO in dark color, the canvas or slide are does not need to have a blurry shadow. Rafael Lima committed a patch related to this issue. It has been pushed to "libreoffice-7-5-0": https://git.libreoffice.org/core/commit/bb5371bc7e05a9f2ae4baa73f618babe732272a3 tdf#152622 Fix color of Object Boundaries in dark mode It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Cannot verify the fix in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e125e6623fa1c0f39d927bb37547ca6d1e299cb1 CPU threads: 8; OS: Mac OS X 13.2; UI render: Skia/Raster; VCL: osx Locale: de-DE (en_DE.UTF-8); UI: en-US Calc: threaded @Rafael: do you have a way to double check this on macOS? (In reply to steve from comment #12) > @Rafael: do you have a way to double check this on macOS? Unfortunately I do not have a way to check it on macOS. Maybe you'll need to reset "User interface modifications" in safe mode. Have you tried that? I think it is fine. It ran briefly in safe mode and was looking good. After adapting the UI reset and restarting I ended up https://bugs.documentfoundation.org/show_bug.cgi?id=147342 preventing any further meaningful interaction with LO 😬 |