Bug 150839

Summary:	View layout has no alternative access method
Product:	LibreOffice	Reporter:	Heiko Tietze <heiko.tietze>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	normal	CC:	79045_79045, eyalroz1, mentoring, vsfoote, xiscofauli
Priority:	medium	Keywords:	accessibility, difficultyMedium, easyHack, skillDesign, topicUI
Version:	unspecified
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=148441
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:	86899, 107343, 109425
Bug Blocks:	86066

Description Heiko Tietze 2022-09-07 05:42:27 UTC

The view layout offers single page, two-pages, and a book mode at the statusbar. Unfortunately we do not provide alternative methods to access it. This not only violates a11y but makes it also hard to understand for novice users.

In particular since the statusbar icons do not have any tooltip.

Comment 1 Heiko Tietze 2022-09-07 05:44:36 UTC

My proposal is to add a menu "Layout" or "Mode" under View just above Zoom and list the three commands there. It clearly violates the HIG and breaks the menu a11y for small screens. Ideally we hide (or rather move) some other items.

Comment 2 Roman Kuznetsov 2022-09-07 07:32:59 UTC

I would add submenu like this:

View -> 
        Pages ->
                 Single page view
                 Multiple pages view
                 Book view

And I would add it to top of the View menu like:

Normal
Web
Pages
---------
User interface
........

Comment 3 Heiko Tietze 2022-09-07 07:42:27 UTC

The tooltip shows up in master / 7.5 but not with 

Version: 7.4.0.3 / LibreOffice Community
Build ID: 40(Build:3)
CPU threads: 8; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (en_US.UTF-8); UI: en-US
7.4.0-3
Calc: threaded

In fact no tooltip at all at the statusbar, toolbar and sidebar do have tips.

Comment 4 V Stuart Foote 2022-09-07 14:30:30 UTC

Had to read this a couple of times to realize you want to add an item to the Main menu. Not make a change to widget on the status bar, nor add it to the Options -> View panel.

The view state buttons on the status bar correspond to 3 views that have defined UNO actions:

.uno:ShowSinglePage
.uno:ShowMultiplePages
.uno:ShowBookview

respectively. So adding them to a menu is already simple and just need to decide placement and labeling. And maybe move the UNO for full screen: .uno:FullScreen onto this sub menu.

Better label than "View -> Pages" might be "View -> Layout".   Pages connotes the position in the document, while Layout would be the right meaning.

Also, on Windows builds at least, the Status bar *does* provide tool tips for every element on the status bar--except the thumb on the zoom slider.

And, what about MUFFIN? Where we've conveniently hidden the Main menu. And the controls remain silent to AT. 

And since you've cast this as an a11y issue, we have never resolved bug 107343--where F10, F6 and standard keyboard movements, shortcuts, and accelerators are integral to providing functional Assistive Technology. We also don't fire accessible events for the 

Otherwise +1, it is needed.

Comment 5 V Stuart Foote 2022-09-07 14:39:56 UTC Comment hidden (obsolete)

(In reply to V Stuart Foote from comment #4)
> also don't fire accessible events for the 

Sorry better finish that.

... accessible events for the Notebook bar bug 190425

Comment 6 V Stuart Foote 2022-09-07 14:59:35 UTC

(In reply to V Stuart Foote from comment #4)
 Sorry better finish that.

... accessible events for the Notebook bar bug 109425

Comment 7 Heiko Tietze 2023-05-05 09:12:38 UTC

Let's do it. Code pointer in comment 4.

Comment 8 V Stuart Foote 2024-04-22 21:57:07 UTC

*** Bug 160785 has been marked as a duplicate of this bug. ***

Comment 9 V Stuart Foote 2024-04-22 22:03:02 UTC

(In reply to V Stuart Foote from comment #4)

> defined UNO actions:
> 
> .uno:ShowSinglePage
> .uno:ShowMultiplePages
> .uno:ShowBookview
> 
> respectively.
Unfortunately looking at this again for dupe bug 160785, and these UNO are only for the Print Preview modes.

I was wrong, sorry!

Actual controls on the Status Bar UI are in viewlayoutctrl.cxx [1] and will need new UNO to implement.

But continue to think addition to the main View would be useful.

Comment 10 Eyal Rozenberg 2024-04-23 09:04:57 UTC

A little bike-shedding by the author of the dupe bug (i.e. me):

* I agree that this should be in a submenu of the View menu.

* I think "pages" is not a good submenu title. It's as though you're supposed to choose whether to view pages; or which pages to view. Perhaps something like "multi-page layout" or "Layout of pages" or "Viewport layout" or "Page placement". None of these are great, maybe you have a better idea

* I think the item titles should be a little more descriptive than with the bottom toolbar, because we don't have the icons to illustrate. So maybe "Single page per row", "Multiple pages per row" and "Book view".