Bug 148438

Steps to reproduce:

1. Open a LibreOffice application of your choice.
2. Open a document (creating a new one may also work, didn’t try specifically).
3. Make some changes to the document.
4. Let things sit long enough for autosave to kick in.
5. Save the document but keep it open.
6. Let things sit for some longer.
7. Kill LibreOffice.
8. Open LibreOffice again.

Expected behavior:

One of the following two:
1. The document is not recovered as it has no unsaved changes (to pick up where you left off, just reopen the document), OR
2. No recovery is performed, the recovery dialog just opens the last saved document.

Actual behavior:

LibreOffice performs a lengthy recovery, even for documents that had no unsaved changes. This takes much longer than opening the document the regular way, and generates the same result.

Environment:

LibreOffice 7.0.5.2 (x64) on Windows 10. This behavior has likely been around all along.

Additional information:

As I understand it, LibreOffice already keeps track of two things:

* list of open documents, persistent across crashes
* for each open document, a “dirty” flag (indicating unsaved changes); nonpersistent and lost after a crash

So the approach would be:

* Store the “dirty” flag with the list of documents to recover (i.e. persistent across crashes)
* When restarting after a crash, either limit the list of documents to recover to those with the “dirty” flag set, or choose the recovery strategy based on the “dirty” flag: if set, do the full recovery; if not set, just open the last saved state