Summary: | Navigator: Proposal to combine Comment category context menu items 'Show All' and 'Hide All' to check menu item 'Show Comments in Document' | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Jim Raykowski <raykowj> |
Component: | Writer | Assignee: | Sujatro Bhadra <sujatrobhadra> |
Status: | ASSIGNED --- | ||
Severity: | enhancement | CC: | heiko.tietze, mentoring, sujatrobhadra |
Priority: | medium | Keywords: | difficultyMedium, easyHack, skillCpp |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | reviewed:2024 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103030, 106179 | ||
Attachments: | Comment context menu change proposal |
Description
Jim Raykowski
2022-03-09 08:48:46 UTC
It seems it fits current functionality. However, the wording *seems* to imply that there might be "show/hide all comments by Foo", or "Hide this", and if those implemented, the "show all" is not the same as a checkbox to enable comments display. But anyway, until it's implemented, my concern is moot. Mike, I think I understand what you are saying. We are able to "Delete All Comments by Author" but not yet implemented is "Show/Hide All Comments by Author". The reason for this proposed change is that "Show All" and "Hide All" Comments context menu items in the Navigator don't toggle the UNO command state for Menu->View->Comments or the Comments visibility button next to the ruler. Without support from (many) users I doubt this function is needed. (struggle even with the "Delete all by"). And FN_HIDE_NOTE_AUTHOR/FN_DELETE_NOTE_AUTHOR were included before the big bang. My take: simplicity first and "[x] Show Comments" (no reason for "in document"). And I would remove the "by author" flavors. The topic was on the agenda of the design meeting but didn't receive further input. needsDevAdvice for comment 3 (remove hide/deletebyauthor functions) Reading the ticket again it seems reasonable to combine the two commands. We use .uno:ShowAnnotations in the View menu for this purpose. The ContextLabel (View >) "Comments" might be inappropriate for the Navigator popup; not sure if this menu shows the pure "Show Comme~nts" or some PopupLabel needs to be added. Code pointer: sw/uiconfig/swriter/ui/navigatorcontextmenu.ui and probably some magic in sw/source/uibase/utlui/content.cxx and sd/source/ui/dlg/navigatr.cxx I would like to work on this. |