Summary: | Double-clicking an element in Navigator shows it in the middle of the document view instead of at the top | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Buovjaga <ilmari.lauhakangas> |
Component: | Writer | Assignee: | Jim Raykowski <raykowj> |
Status: | VERIFIED FIXED | ||
Severity: | trivial | CC: | raykowj |
Priority: | low | Keywords: | bibisected, bisected, regression |
Version: | 7.2.0.0.alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=137838 | ||
Whiteboard: | target:7.4.0 target:7.3.1 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103030 |
Description
Buovjaga
2022-01-28 13:29:33 UTC
Hi Buovjaga, I was not able to repro following the STR but looking at the bibisected patch I see what happened: -// force scroll to cursor position when navigating to inactive document -if(!bSel) +// assure visible view area is at cursor position + if (!m_pActiveShell->IsCursorVisible() && !m_pActiveShell->IsFrameSelected() && !m_pActiveShell->IsObjSelected()) The GotoOutline function brings the heading into view so it doesn't get force scroll to the top. Easy enough to revert to previous behavior: https://gerrit.libreoffice.org/c/core/+/129129 Thanks for the quick response. I confirm the patch puts back the old behaviour. Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b0434f62c17b69e10caf05ad85a60f1bffdb5238 tdf#147041 Always show navigated heading at top of visible view area It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Should we cherry pick it to 7-3 so it gets into 7.3.1? (In reply to Buovjaga from comment #4) > Should we cherry pick it to 7-3 so it gets into 7.3.1? Sure, I'll try. This is the first time I've cherry picked using gerrit. I've did it locally for fun. https://gerrit.libreoffice.org/c/core/+/129080 Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/c6c343db72a97bb027ccb493cef6fa7f1025f119 tdf#147041 Always show navigated heading at top of visible view area It will be available in 7.3.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |