Summary: | "Go To" control in Navigator must not accept other than numeric values | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | goodguy00 <goodguy00> |
Component: | Writer | Assignee: | Matt K <mattkse> |
Status: | VERIFIED FIXED | ||
Severity: | trivial | CC: | dgp-mail, heiko.tietze, LibreOffice, mentoring |
Priority: | medium | Keywords: | easyHack, skillDebug, topicUI |
Version: | 7.1.8.1 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:24.2.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103030 |
Description
goodguy00@zoho.com
2021-12-16 16:42:34 UTC
"$" in the Go to Page field and Enter, makes the cursor jump to the start (upper left) of the last page; but if do you do "$" Enter again, the cursor jumps to the start (upper left) of the first page. And instead of "$": "·", "%", "ç", uppercase characters, """, etc. With lowercase characters it behaves a bit erratically. Version: 7.1.8.1 / LibreOffice Community Build ID: e1f30c802c3269a1d052614453f260e49458c82c CPU threads: 1; OS: Linux 4.12; UI render: default; VCL: x11 Locale: es-MX (es_AR.UTF-8); UI: en-US Calc: threaded REPRODUCIBLE with Installation of Version 7.2.4.1 (x64) / LibreOffice Build 27d75539669ac387bb498e35313b970b7fe9c4f9 CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win; Locale: de-DE (de_DE); UI: de-DE; Calc: threaded; Elementary Theme; My normal User Profile Navigator accepts non numeric characters, page navigation dialog does not. UX should decide which is correct behavior. My opinion: reject non numerics. Indeed, I would expect consistent behavior. 4.0.0 did not accept non numeric characters personally, i would prefer at least the '$' for last page. (In reply to Rainer Bielefeld Retired from comment #2) > REPRODUCIBLE with Installation of Version 7.2.4.1 (x64) / LibreOffice > Build 27d75539669ac387bb498e35313b970b7fe9c4f9 > CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: > win; Locale: de-DE (de_DE); UI: de-DE; Calc: threaded; Elementary Theme; My > normal User Profile > Navigator accepts non numeric characters, page navigation dialog does not. > > UX should decide which is correct behavior. My opinion: reject non numerics. > > Indeed, I would expect consistent behavior. > > 4.0.0 did not accept non numeric characters Not sure about the meaning of comment 4, but I confirm behaviour with Version: 7.4.3.2 (x64) / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL So clearly a bug and design-team should decide about solution. The numerical spin edit fields are not meant for some cryptic vi-like commands. Having $ jumping to the last value is just a fortuitous result. So I agree with Rainer to accept only numbers in the Navigator field. The "Go-To-Page" dialog works as expected. Code pointer: sw/uiconfig/swriter/ui/navigatorpanel.ui uses a GtkAdjustment and code in sw/source/uibase/utlui/navipi.cxx does m_xEdit->set_max(nPageCnt); as I'd expect. Needs some debugging... Fix located at https://gerrit.libreoffice.org/c/core/+/154156. Added Heiko to the review. Matt K committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7019eef453954785ad039bebd8c8a00183992584 tdf#146273 Do not allow non-numeric values for Navigator "Go to" It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. VERIFIED with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e25e27c85ed970cdb97c468bdac86c80964f4231 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded Matt, thanks for fixing it! Actual result: non-numeric value is replaced by "1" |