Summary: | UI: Manage Changes dialog shows the format changes with the same green + icon as insert changes | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Telesto <telesto> |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | heiko.tietze, kainz.a, mentoring, michael.stahl, rizmut |
Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillDesign, topicDesign |
Version: | Inherited From OOo | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:7.1.0 target:7.0.2 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 83946 |
Description
Telesto
2020-07-29 10:39:17 UTC
Yes, we should introduce a different icon. The sidebar deck (experimental feature) also shows a green plus (Karasa Jaga them) for both content and format-only changes. See also the proposal at https://design.blog.documentfoundation.org/2015/02/19/tracking-changes-with-libreoffice/ Does this requires code changes or is it a question to the icon designers, Michael? so we have SwRedlineAcceptDlg::GetActionImage in sw/source/uibase/misc/redlndlg.cxx which refers to these in sw/inc/bitmaps.hlst #define BMP_REDLINE_INSERTED "sw/res/redline_inserted.png" #define BMP_REDLINE_DELETED "sw/res/redline_deleted.png" #define BMP_REDLINE_FORMATTED "sw/res/redline_inserted.png" #define BMP_REDLINE_TABLECHG "sw/res/redline_inserted.png" #define BMP_REDLINE_FMTCOLLSET "sw/res/redline_inserted.png" so i guess just add new icons wherever the current ones are and change these strings? Rizal, Andreas: Could you please take a look? (In reply to Michael Stahl (CIB) from comment #2) > so we have SwRedlineAcceptDlg::GetActionImage in > sw/source/uibase/misc/redlndlg.cxx > > which refers to these in sw/inc/bitmaps.hlst > > #define BMP_REDLINE_INSERTED "sw/res/redline_inserted.png" > #define BMP_REDLINE_DELETED "sw/res/redline_deleted.png" > #define BMP_REDLINE_FORMATTED "sw/res/redline_inserted.png" > #define BMP_REDLINE_TABLECHG "sw/res/redline_inserted.png" > #define BMP_REDLINE_FMTCOLLSET "sw/res/redline_inserted.png" > > so i guess just add new icons wherever the current ones are and change these > strings? please give me the desired changes, so I can add missing icons. Better we provide all three variables with their dedicated icons (BMP_REDLINE_FORMATTED, BMP_REDLINE_TABLECHG and BMP_REDLINE_FMTCOLLSET). Please give me an explanation what each of variable means? (In reply to Rizal Muttaqin from comment #4) > please give me the desired changes, so I can add missing icons. Better we > provide all three variables with their dedicated icons > (BMP_REDLINE_FORMATTED, BMP_REDLINE_TABLECHG and BMP_REDLINE_FMTCOLLSET). > Please give me an explanation what each of variable means? FORMATTED: some formatting has changed, but we can't tell what exactly TABLECHG: something experimental and unimplemented, probably having to do with tables FMTCOLLSET: something experimental and unimplemented, probably having to do with styles (In reply to Michael Stahl (CIB) from comment #5) > (In reply to Rizal Muttaqin from comment #4) > > please give me the desired changes, so I can add missing icons. Better we > > provide all three variables with their dedicated icons > > (BMP_REDLINE_FORMATTED, BMP_REDLINE_TABLECHG and BMP_REDLINE_FMTCOLLSET). > > Please give me an explanation what each of variable means? > > FORMATTED: some formatting has changed, but we can't tell what exactly > > TABLECHG: something experimental and unimplemented, probably having to do > with tables > > FMTCOLLSET: something experimental and unimplemented, probably having to do > with styles This is the patch https://gerrit.libreoffice.org/c/core/+/99868 Other icon themes will follow, I.A. Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/703809e1c9451ecf488b8fba09ed0c72d9468bbd tdf#135265 Add icon variants in Manage Changes dialog It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/72268f475d9c5f85c1c2195218cc41cf273f7dc6 tdf#135265 Add icon variants in Manage Changes dialog It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Rizal Muttaqin committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/573ba0412a7ded5d510d37bb533135b6ff012b4f tdf#135265 Add icon variants in Manage Changes dialog It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I just checked and every icon theme now displays different icon for formatting changes. |