Summary: | Edit with external tool causes a CPU hit | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Buovjaga <ilmari.lauhakangas> |
Component: | Writer | Assignee: | Tomofumi Yagi <yagit> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mentoring, michael.meeks, telesto, yagit |
Priority: | medium | Keywords: | bibisected, difficultyBeginner, easyHack, haveBacktrace, perf, regression, skillCpp, topicCleanup |
Version: | 5.1.0.3 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:7.1.0 target:7.0.2 target:6.4.7 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 136524, 113510 | ||
Attachments: | Perf flamegraph |
Description
Buovjaga
2020-06-19 19:26:24 UTC
Yup Version: 7.1.0.0.alpha0+ (x64) Build ID: 43c60ce1ac7629a1462e927e6ff937469f58f743 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Perf graph is based on empty doc + image I assume.. for me it starting iterating text Well - the idle work is fine - we do fast idles, when we are idle. Of course if someone makes a busy loop using an idle handler that never completes - we hit 100% CPU. If they leak that busy idle handler then ... we get this effect. I would go read the edit with external tool code, and work out why an idle handler is used there, and/or turn it into a 250ms timeout or so. HTH =) Code pointer: include/svtools/filechangedchecker.hxx:class UNLESS_MERGELIBS(SVT_DLLPUBLIC) FileChangedChecker include/svtools/filechangedchecker.hxx-{ include/svtools/filechangedchecker.hxx-private: include/svtools/filechangedchecker.hxx- Idle mIdle; Should be a timeout. Tomofumi Yagi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f110c037114f90d219ac8d149542bf96fe66a2f1 tdf#134157 fix Edit with external tool causes a CPU hit It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks, Tomofumi, I verify the fix! Arch Linux 64-bit Version: 7.1.0.0.alpha0+ Build ID: 1f07c2e440326f2b2c8ffbb53c91570e6cfcd74d CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: kf5 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 19 September 2020 Tomofumi Yagi committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/1d28170d94893171e2a358274cda62cd73f7b834 tdf#134157 fix Edit with external tool causes a CPU hit It will be available in 7.0.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tomofumi Yagi committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/bd1345f9806b1bb9940d208d75610f7c4556f05d tdf#134157 fix Edit with external tool causes a CPU hit It will be available in 6.4.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tomofumi Yagi committed a patch related to this issue. It has been pushed to "libreoffice-7-0-2": https://git.libreoffice.org/core/commit/d62fe22aed6acf36c5321a417beb4c37a5f715a2 tdf#134157 fix Edit with external tool causes a CPU hit It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tomofumi: feel free to change status to fixed. (In reply to Buovjaga from comment #9) > Tomofumi: feel free to change status to fixed. Bump |