Bug 132155

Summary: UI: Toolbar looks different (there is depth effect); SKIA Raster&Vulkan
Product: LibreOffice Reporter: Telesto <telesto>
Component: LibreOfficeAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED INVALID    
Severity: normal CC: aron.budea, l.lunak, vsfoote
Priority: medium    
Version: 7.0.0.0.alpha0+   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 129062    
Attachments: Screenshot
Comparison Screenshot
full res screen clips of Writer in GDI, OpenGL, Skia Vulkan, Skia Raster
Screenshot 300% zoom

Description Telesto 2020-04-16 17:53:49 UTC
Description:
UI: Toolbar looks different (there is depth effect)

Steps to Reproduce:
1. Open attachment 155421 [details]
alternative: open Draw

Actual Results:
See screenshot

Expected Results:
Same as normally


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 4475bcd83aac7e033fc5250f268eb922bd471e7b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Vulkan; VCL: win; 
Locale: en-US (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Telesto 2020-04-16 17:54:09 UTC
Created attachment 159638 [details]
Screenshot
Comment 2 Luboš Luňák 2020-04-22 09:49:26 UTC
What exactly am I supposed to see?
Comment 3 Telesto 2020-04-22 10:33:30 UTC
Created attachment 159810 [details]
Comparison Screenshot
Comment 4 Telesto 2020-04-22 10:33:53 UTC
Note: not only Skia also OpenGL
Comment 5 V Stuart Foote 2020-04-22 13:00:07 UTC
Consistent to OpenGL rendering so => NAB against Skia rendering

Related issues of 3D effects in UI by differing os/DE
bug 46973
bug 57433
bug 59329
even
bug 125608
Comment 6 Luboš Luňák 2020-04-22 13:17:49 UTC
If this is different between Windows GDI and Skia, then this is a valid bugreport (and Skia uses the same mechanism for widget drawing as OpenGL, so OpenGL is no excuse here).

But still, what is it that I am supposed to see? The line above and below the toolbar area that looks like an off-by-one error somewhere?
Comment 7 Telesto 2020-04-22 13:59:59 UTC
> But still, what is it that I am supposed to see? The line above and below
> the toolbar area that looks like an off-by-one error somewhere?

It's in the detail. Zoom in on the PDF. Look at transition from menubar to toolbar. The toolbar is more 'yellow' compared to the toolbar (gray)

And this doesn't appear to be Skia/OpenGL in general. It's also different between applications. Flat in Calc. Depth in Writer. It's going on for a while an certainly a regression. 

Doesn't happen with GDI
Comment 8 V Stuart Foote 2020-04-22 14:04:27 UTC
@Luboš, * 

There have been subtle differences in rendering the GUI between OpenGL and Default GDI since OpenGL was implemented. Flat border vs. 3D gradient border edge for many widgets and frame elements.

Admittedly, more folks may see them for first time with transition to Skia (Raster, or Vulkan where supported).  OpenGL support was kind of a high hurdle for some os/DE and hw/driver pairings--a lot of users never could run it.

But, don't see it a fair to your Skia work to at this point 'doink' Skia for GUI nuisances that have been around for years.
Comment 9 V Stuart Foote 2020-04-22 15:32:45 UTC
Created attachment 159819 [details]
full res screen clips of Writer in GDI, OpenGL, Skia Vulkan, Skia Raster

We know there are os/DE rendering differences, even between builds of Windows

If I recall correctly, Telesto is on Windows 8.1 with Intel GPU

I'm on Windows 10 with Intel HD Graphics 620 on a 1920x1080 (~115dpi screen) with the 2020-04-17 TB77 build, and get rather different rendering results--with differences between GDI and OpenGL, and Skia rendering less pronounced as in the attached mashup of clips.

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 96f77910e86f88c99621a8b17c09fc69f9f1d8f3
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; Locale: en-US (en_US); UI-Language: en-USCalc: threaded

All thinkgs being equal IMHO => NAB, just variances in GPU rendering support by os/DE and hw/Driver.
Comment 10 Telesto 2020-04-22 16:02:08 UTC
Created attachment 159820 [details]
Screenshot 300% zoom
Comment 11 Telesto 2020-04-22 16:08:09 UTC
(In reply to V Stuart Foote from comment #9)
> Created attachment 159819 [details]
> full res screen clips of Writer in GDI, OpenGL, Skia Vulkan, Skia Raster

Thanks for the screenshot. Not seeing any problem.. However I'm seeing something else.

I'm using Skia/Raster.. so software mode.. This is really a recent issue.. It's going on for a month or so. It's neither consistent. Calc fine, Draw broken. I noticed it first in Draw, I think.. Will attempt a bibisect
Comment 12 Telesto 2020-04-26 19:46:24 UTC
Profile madness?