Summary: | Fileopen and Filesave: XLSX with Boolean value wrong if saved and resaved, MSO repairs file | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | BUATOIS <cbuatois> |
Component: | Calc | Assignee: | Eike Rathke <erack> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aron.budea, erack, himajin100000, ilmari.lauhakangas, libreoffice, pierre.castagno |
Priority: | medium | Keywords: | bibisected, bisected, filter:xlsx, regression |
Version: | 6.0.2.1 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=81350 https://bugs.documentfoundation.org/show_bug.cgi?id=115351 |
||
Whiteboard: | target:7.3.0 target:7.2.0.0.beta2 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 104839 | ||
Attachments: |
Simpe test ODS
Example file saved to xlsx twice with en-US locale - good Example file saved to xlsx twice with hu-HU locale - bad |
Description
BUATOIS
2018-12-19 09:33:38 UTC
No repro LO 5.0 and 6.0. Reproduced in LO 6.3+. But, as they say, if it looks like a regression and behaves like regression, it still doesn't have to be regression. Unless proved differently with some quick bibisect. English UI will also do and show bug. Steps: 1. make a cell with Boolean value TRUE 2. Save as XLSX and close 3. Reopen, see that value is right in LO (and MSO) 4. Save again as XLSX and close 5. Reopen in LO, see "BOOL99AN" (and reopen in MSO and see problem with content) Created attachment 147675 [details]
Simpe test ODS
*** Bug 120664 has been marked as a duplicate of this bug. *** Bibisected with win32-6.1 to https://gerrit.libreoffice.org/plugins/gitiles/core/+/ce4fc2fc08be8ea2773194e303ed42d2579e93a0%5E!/ Resolves: tdf#115351 convert boolean equivalent format codes to proper Boolean Adding Cc: to Eike Rathke This also seems to be locale-dependent: - Not reproduced with en-US - Reproduced with hu-HU Version: 7.0.0.0.alpha0+ (x64) Build ID: 54b28638ab15f68731861ae903c732273b41f78a CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; Locale: hu-HU (hu_HU); UI-Language: en-US Calc: CL Created attachment 157663 [details]
Example file saved to xlsx twice with en-US locale - good
Created attachment 157664 [details]
Example file saved to xlsx twice with hu-HU locale - bad
This somehow went under my radar, taking. Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7a58221f800e215934cbcb2d3907c35b44981611 Resolves: tdf#122191 BOOLEAN is a keyword, treat it as such It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/b92718fe3e9c873dc7d5a3aee66fb2adb780861a Resolves: tdf#122191 BOOLEAN is a keyword, treat it as such It will be available in 7.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/aa5acdda9a1bd05263e482c4f527be6d088edde6 tdf#122191: sc_subsequent_export-test2: Add unittest It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |