Summary: | FILEOPEN DOCX The paragraph formatting changes are not undone / freeze LO | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Gabor Kelemen (allotropia) <kelemeng> |
Component: | Writer | Assignee: | Henry Castro <hcastro> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aron.budea, hcastro, libreoffice, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 6.1.0.3 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=101977 https://bugs.documentfoundation.org/show_bug.cgi?id=124162 https://bugs.documentfoundation.org/show_bug.cgi?id=45763 |
||
Whiteboard: | target:6.3.0 target:6.2.5 target:6.4.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 83946, 115709 | ||
Attachments: |
Example file from Word with a paragraph formatting change.
Screenshot of the problem in Writer. (step 8) |
Description
Gabor Kelemen (allotropia)
2018-10-05 09:55:27 UTC
Created attachment 145408 [details]
Screenshot of the problem in Writer. (step 8)
Bibisected with bibisect-win32-6.0: $ git bisect log # bad: [bc1845d882e52469a4583747881a465749177829] source c30963b8b4bbbe42a24b97aafa161eff9d7ccdd4 # good: [cc5c4c7ed1d8d01b0063bcaaeb5f6d59282c8029] source 9feb7f7039a3b59974cbf266922177e961a52dd1 git bisect start 'origin/master' 'oldest' # good: [611b687719dc875499fd14d50e699b7ce871b941] source 2cd664b3d618e6085be8b44ee86eada6cd5f8789 git bisect good 611b687719dc875499fd14d50e699b7ce871b941 # good: [3d50ca0e4e00109fa4799c8bb6c0093ec33c58ba] source 0c364fa7d507ae41bf04d36464f8942d154e49c0 git bisect good 3d50ca0e4e00109fa4799c8bb6c0093ec33c58ba # bad: [2678a952310db3696fc39c4763455b12843429fb] source a27f26228c8311b3b01ecca81d6cdcd3ceb644e1 git bisect bad 2678a952310db3696fc39c4763455b12843429fb # bad: [6f94faac21b6f3988c9a4b22aa5ef090a3a4f1ae] source b73c66597884f03443ee8888cb6c204b78bb6cda git bisect bad 6f94faac21b6f3988c9a4b22aa5ef090a3a4f1ae # good: [b3014bb832ec89aaf3256433aeeed78080729675] source 0d50804e1c0c0ea2a5cd73fa3fa2a9ff0a0e7048 git bisect good b3014bb832ec89aaf3256433aeeed78080729675 # bad: [efcd5fd7720f9771d20b634df314dc10010bb19c] source 899d7139355b8bea4bc1e6f9c05dededdb6f2c39 git bisect bad efcd5fd7720f9771d20b634df314dc10010bb19c # good: [6da362e0441edd8e9f25b699d58d52436c77bf68] source 2168080905e9dbdc6100a34399a39b1a2df1975f git bisect good 6da362e0441edd8e9f25b699d58d52436c77bf68 # bad: [904ae908279a1ac4215e90c8b03464f9a9d7e8ef] source 174e881caa720770699857cf09e30d0d1be4a89e git bisect bad 904ae908279a1ac4215e90c8b03464f9a9d7e8ef # good: [855bbe83f40113b888167750ed6c9b168be726a5] source 1ad3f06427fc6c9da106666768fdf5b16a7bfc6b git bisect good 855bbe83f40113b888167750ed6c9b168be726a5 # bad: [42a7fcb47e24a405d4d169b88c194faf225539ac] source 03033ae8abcb774fa58273eebac93dbfecab641d git bisect bad 42a7fcb47e24a405d4d169b88c194faf225539ac # good: [8064703b97140313bc29c01b0429daf816d6fa21] source a6ee721868f444049bf9af59e2cf43ae10502fa8 git bisect good 8064703b97140313bc29c01b0429daf816d6fa21 # bad: [ede06ff904111e570dc21d924d4dd0b51742270d] source b273aa535cdddd1f10d13551d5330149d3404c3a git bisect bad ede06ff904111e570dc21d924d4dd0b51742270d # bad: [0a1bc44727cfa3b16fc0ed9c6c9494849b6551b2] source 2db44bd017daac8f668393bca24911e95125857a git bisect bad 0a1bc44727cfa3b16fc0ed9c6c9494849b6551b2 # first bad commit: [0a1bc44727cfa3b16fc0ed9c6c9494849b6551b2] source 2db44bd017daac8f668393bca24911e95125857a https://cgit.freedesktop.org/libreoffice/core/commit/?id=2db44bd017daac8f668393bca24911e95125857a Adding Cc: to Henry Castro Even with the recent work done on bug #124162 (crash on Accept all), choosing Reject all on the example file still puts Writer in an endless loop. Version: 6.3.0.0.alpha0+ Build ID: c18179cf80516f1eca9629a0a8b888e0ca67a020 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: hu-HU (hu_HU.UTF-8); UI-Language: en-US Calc: threaded Hi, Thanks for report, unfortunately reject paragraph formatting is not implemented yet (will ask co-worker if he has plans to implement it), but I fixed the endless loop that was a side effect to "Reject All" command https://gerrit.libreoffice.org/#/c/69865/ Regards Henry Henry Castro committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/c033d8e5a662eec3c1104b70f33cf0795c8c211c%5E%21 tdf#120338: The paragraph formatting changes are not undone, part 1 It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Endless loop verified in Version: 6.3.0.0.alpha1+ Build ID: f897342320ad3a29cf4be1437c8e3ce888bdb3cb CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Henry Castro, thanks for fixing this!! Cherry-picked to libreOffice 6.2 branch -> https://gerrit.libreoffice.org/#/c/72404/ Henry Castro committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/2f184d792f5af4a97e4f0c07b0bad19a4c3e9589%5E%21 tdf#120338: The paragraph formatting changes are not undone, part 1 It will be available in 6.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/05526a206cc8a273771b2e6aae1fd3c4092cbf03%5E%21 tdf#120338 DOCX: add rejection of paragraph formatting changes It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b86b87eb34c686c67ae86c6f635e5218a5654898%5E%21 tdf#120338 DOCX: reject other paragraph formatting changes It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |