Summary: | Merge toolbar "More Forms" with "Form Controls" | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Samuel Mehrbrodt (allotropia) <samuel.mehrbrodt> |
Component: | Writer | Assignee: | Roman Kuznetsov <79045_79045> |
Status: | VERIFIED FIXED | ||
Severity: | enhancement | CC: | 79045_79045, dgp-mail, ilmari.lauhakangas, mentoring, philipz85, samuel.mehrbrodt |
Priority: | low | Keywords: | difficultyBeginner, easyHack, skillCpp, skillUI, topicCleanup, topicUI |
Version: | Inherited From OOo | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=125947 https://bugs.documentfoundation.org/show_bug.cgi?id=126611 https://bugs.documentfoundation.org/show_bug.cgi?id=126634 https://bugs.documentfoundation.org/show_bug.cgi?id=131239 |
||
Whiteboard: | target:6.3.0 target:6.4.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103239, 107742 |
Description
Samuel Mehrbrodt (allotropia)
2017-09-15 15:38:58 UTC
In LO 5.3.6.1 I only can see one toolbar with 13 buttons. Yes. Thought of the same issue as well when i was changing around the buttons in these two toolbars. Also the toolbar has a button for 'Form Design' which opens the Form Design toolbar, so it would be great if we could merge all three toolbars into one. The "Form Controls" toolbar is defined in sw/uiconfig/swform/toolbar/formcontrols.xml and the "More controls" toolbar is defined in sw/uiconfig/swform/toolbar/moreformcontrols.xml. The items from moreformcontrols should be placed in formcontrols and the code to show the "More controls" toolbar should be removed. The suggestion from Jay in comment 3 can be handled in a different ticket. (In reply to Samuel Mehrbrodt (CIB) from comment #4) > The "Form Controls" toolbar is defined in > sw/uiconfig/swform/toolbar/formcontrols.xml and the "More controls" toolbar > is defined in sw/uiconfig/swform/toolbar/moreformcontrols.xml. > > The items from moreformcontrols should be placed in formcontrols and the > code to show the "More controls" toolbar should be removed. > > The suggestion from Jay in comment 3 can be handled in a different ticket. 1. There are formcontrols.xml and moreformcontrols.xml for Writer, Calc, Draw, Impress, sweb, sglobal, swform, swreport, swxform. May be need to change it all into one toolbar for every module? 2. Don't need merge Form Controls and Form Design because: 2.1 it have different actions, first for create of controls second for handle of controls on page 2.2 it will be very large toolbar (In reply to Roman Kuznetsov from comment #5) > 1. There are formcontrols.xml and moreformcontrols.xml for Writer, Calc, > Draw, Impress, sweb, sglobal, swform, swreport, swxform. May be need to > change it all into one toolbar for every module? Yes. > 2. Don't need merge Form Controls and Form Design because: > 2.1 it have different actions, first for create of controls second for > handle of controls on page > 2.2 it will be very large toolbar Ok, then we leave that as it is. Roman Kuznetsov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/e89eba0e1fa56c64e0d572b4f32ce5951378c1d7%5E%21 tdf#112411 Merge "Form controls" and "More controls" into one toolbar It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Roman Kuznetsov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/00f96e88a7c6feea98d446e82a2718c5aae6256c%5E%21 tdf#112411 Remove all that remains of the More controls toolbars It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/+/7eab913ccdb60bfaa2e1fd46b940957773b17825%5E%21 tdf#112411 (related) No more More Controls toolbar issue related to this fix: there are now two missing buttons in the default layout -> https://bugs.documentfoundation.org/show_bug.cgi?id=125947 (In reply to stragu from comment #10) > issue related to this fix: there are now two missing buttons in the default > layout -> https://bugs.documentfoundation.org/show_bug.cgi?id=125947 I'll fix it Am hoping that these changes aren't the cause for https://bugs.documentfoundation.org/show_bug.cgi?id=126611 (In reply to Commit Notification from comment #9) > Gabor Kelemen committed a patch related to this issue. > It has been pushed to "master": > tdf#112411 (related) No more More Controls toolbar I can verify it with Version: 6.4.0.0.alpha0+ (x64) Build ID: 3e64065612acec2eb29aa21e2b515953422256d7 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-08-15_22:57:26 Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded I'm not sure if my finding could be add to this bug report or not 1. Open up LibreOffice Basic (Tools > Macros > Edit Macros ...) 2. In menu bar, go to Dialog and we can find "More Fields" here. Also in LibreOffice Base: Database Form 1. Open a Base file 2. In menu bar, go to View > Forms, and click Create Form in Design View... 3. A Database Form window appear, go to Form menu bar and we can find "More Fields" again Same also in Writer's Form menu. Should we remove this "More Fields" submenu to unify all menu items? |