Summary: | Wrong Behaviour of Undo in Writer With Index Entry | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Kevin Suo <suokunlong> |
Component: | Writer | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | michael.stahl, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected |
Version: | 4.1.0.4 release | ||
Hardware: | All | ||
OS: | Linux (All) | ||
Whiteboard: | target:5.4.0 target:5.3.3 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 105948 |
Description
Kevin Suo
2017-03-07 07:28:00 UTC
Bibsecting using the bibisect-releases repo suggested that the behaviour has changed since libreoffice-4.1.0.0.beta1, although versions before 4.1.0.0.beta1 also behaves wrong. In versions before 4.1.0.0.beta1 (including the old OpenOffice.org), each roundtrip of step 5 and 6 you will loose one char. (i.e., "Hello World!" > "ello World!" > "llo World" > ...). In all versions after 4.1.0.0. beta1, you get "ello World!!!br0ken!!" at the end. Confirm in Version: 5.4.0.0.alpha0+ Build ID: d3676ceeec55a41337ce5e6bc596f4f100d0638e CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk2; Locale: ca-ES (ca_ES.UTF-8); Calc: group Regression introduced by: author Michael Stahl <mstahl@redhat.com> 2013-02-18 17:36:45 (GMT) committer Michael Stahl <mstahl@redhat.com> 2013-02-18 19:16:07 (GMT) commit 0295c8a34e39326414c1b98cf4da905802f061b0 (patch) tree 0595896589edc155fae7775fe586403c59842379 parent 24eae2b75c201292990122e69954072f36b6f218 (diff) sw: let SwTxtNode::GetTxt() return OUString Adding Cc: to Michael Stahl This is not a regression, can reproduce the bug already in OOo 3.0.1, it's just that the bug became more visible. when deleting it from the dialog the wrong undo object is created, it works for marks with start and end but this one doesn't have an end. it looks like this problem only affects ToXMarks, the other ones without end (reference marks, fields, footnotes) apparently don't have a dialog that can *delete* them. which raises the question why ToXMarks have a delete button in the dialog. fixed on master Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=63f7da77985674ddf59bb566bdada9c41893e822 tdf#106377 sw: fix Undo of delete of ToXMark from dialog It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=123bb36e7eafde85732b57e84d0377586a0a66d8&h=libreoffice-5-3 tdf#106377 sw: fix Undo of delete of ToXMark from dialog It will be available in 5.3.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |