Bug 105187

Summary: Warn user that renaming an object (e.g. a linked image) will break the hyperlink
Product: LibreOffice Reporter: Telesto <telesto>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: enhancement CC: buzea.bogdan, cno, heiko.tietze, raykowj, thomas.lendo, vsfoote
Priority: medium    
Version: Inherited From OOo   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 107733    
Attachments: Example file

Description Telesto 2017-01-08 14:03:34 UTC 
Description:
Insert hyperlinks tend to break, if the image gets renamed



Steps to Reproduce:
1.Open attached file
2.Go to sidebar -> Navigator 
3. Expand images -> Right Click -> Click Rename
4. Rename it to something different
5.Try to use the link

Actual Results:  
Hyperlink will be broken after renaming an image

Expected Results:
Quite hard to tell. Multi options:
1. Most ideal a dynamic update of all hyperlinks (seems quite complex)
2. Hyperlinks which aren't depending on image naming
3. A warning before renaming a linked object



Reproducible: Always

User Profile Reset: No

Additional Info:
Version: 5.4.0.0.alpha0+
Build ID: 92a1ad1f36b6d3cc13135a8c0805508933011577
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-06_23:42:59
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Comment 1 Telesto 2017-01-08 14:04:43 UTC 
Created attachment 130257 [details]
Example file
Comment 2 V Stuart Foote 2017-01-08 15:51:09 UTC 
Sorry, but this seems correct. 

If you rename the image object--the link still points to the old name.

And note that the actual link object can also be edited, both its Text--but also its target.

The pair of target and link have to be adjusted together--again that seems correct.

Should the user be warned? Maybe... but how much nagging is appropriate?

Otherwise this is not a bug -> Enhancement
Comment 3 Cor Nouws 2017-01-08 20:46:15 UTC 
(In reply to V Stuart Foote from comment #2)

> Should the user be warned? Maybe... but how much nagging is appropriate?

Yeah.. :)
If we nag, please only if there are links to the objects in use. And that will prolly disqualify this as an easy hack.
Comment 4 Heiko Tietze 2017-01-08 21:14:15 UTC 
The confirmation dialog interrupts the workflow, so would an infobar be too much? I think so. The message has to progressively disappear, at best in a callout.
Comment 5 Heiko Tietze 2017-01-15 11:01:24 UTC Comment hidden (no-value)
Comment 6 Heiko Tietze 2020-03-17 09:55:41 UTC 
So much time without any discussion neither a decision. So let's just introduce another state for hyperlinks when the target is not reachable (likely restricted to internal objects). It's known from Wikipedia as red link https://en.wikipedia.org/wiki/Help:Link_color

Jim, something for you?
Comment 7 Jim Raykowski 2020-03-25 23:13:47 UTC 
(In reply to Heiko Tietze from comment #6)
> So much time without any discussion neither a decision. So let's just
> introduce another state for hyperlinks when the target is not reachable
> (likely restricted to internal objects). It's known from Wikipedia as red
> link https://en.wikipedia.org/wiki/Help:Link_color
> 
> Jim, something for you?

Looking around in the area of the code that does the 'Internet Link' and 'Visited Internet Link' character style assignment, this doesn't look like an easy hack to add a 'Broken Internet Link' state. Adding a character style for this doesn't look difficult. Keeping track of if the link is good or broke is the challenge.
Comment 8 BogdanB 2024-03-16 18:20:49 UTC 
Also in
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d097dbc8688b32e7865eca3baab1dd406c306441
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded