Attachment 189069 Details for Bug 156539 – Debug patch that reproduces bug with Skia/Metal on macOS

[patch] Debug patch that reproduces bug with Skia/Metal on macOS

reproducebuginskiametal.diff (text/plain), 1.32 KB, created by Patrick Luby (volunteer) on 2023-08-21 12:52:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Patrick Luby (volunteer)

Created: 2023-08-21 12:52:54 UTC

Size: 1.32 KB

patch

obsolete

>diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
>index 3f42546b930d..639099af70b0 100644
>--- a/vcl/skia/gdiimpl.cxx
>+++ b/vcl/skia/gdiimpl.cxx
>@@ -815,6 +815,8 @@ void SkiaSalGraphicsImpl::drawPolygon(sal_uInt32 nPoints, const Point* pPtAry)
>     drawPolyPolygon(basegfx::B2DHomMatrix(), basegfx::B2DPolyPolygon(aPolygon), 0.0);
> }
> 
>+static bool bInSlideshow = false;
>+
> void SkiaSalGraphicsImpl::drawPolyPolygon(sal_uInt32 nPoly, const sal_uInt32* pPoints,
>                                           const Point** pPtAry)
> {
>@@ -835,7 +837,9 @@ void SkiaSalGraphicsImpl::drawPolyPolygon(sal_uInt32 nPoly, const sal_uInt32* pP
>         }
>     }
> 
>+    bInSlideshow = true;
>     drawPolyPolygon(basegfx::B2DHomMatrix(), aPolyPolygon, 0.0);
>+    bInSlideshow = false;
> }
> 
> void SkiaSalGraphicsImpl::drawPolyPolygon(const basegfx::B2DHomMatrix& rObjectToDevice,
>@@ -902,6 +906,7 @@ void SkiaSalGraphicsImpl::performDrawPolyPolygon(const basegfx::B2DPolyPolygon&
>         // Skia doesn't draw empty polygons, so in that case ensure the line is drawn.
>         if (!moLineColor && polygonPath.getBounds().isEmpty())
>             aPaint.setStyle(SkPaint::kStroke_Style);
>+        if (!bInSlideshow)
>         getDrawCanvas()->drawPath(polygonPath, aPaint);
>     }
>     if (moLineColor && moLineColor != moFillColor) // otherwise handled by fill

Actions: View

Attachments on bug 156539: 188661 | 188663 | 188796 | 189069